refactor(demos): remove programmatic usage of ngOnDestroy

michaelbe812 · michaelbe812 · commit c5e8d2d784b9 · 2025-01-07T05:26:10.000+01:00
diff --git a/apps/demos/src/app/features/tutorials/basics/5-side-effects/side-effects.solution.component.ts b/apps/demos/src/app/features/tutorials/basics/5-side-effects/side-effects.solution.component.ts
@@ -2,7 +2,6 @@ import {
   ChangeDetectionStrategy,
   Component,
   Input,
-  OnDestroy,
   OnInit,
   Output,
 } from '@angular/core';
@@ -74,7 +73,7 @@ const initComponentState = {
 })
 export class SideEffectsSolution
   extends RxState<ComponentState>
-  implements OnInit, OnDestroy
+  implements OnInit
 {
   model$ = this.select();
 
diff --git a/apps/demos/src/app/shared/debug-helper/value-provider/primitives-provider.service.ts b/apps/demos/src/app/shared/debug-helper/value-provider/primitives-provider.service.ts
@@ -59,7 +59,6 @@ export class PrimitivesProviderService {
   };
 
   private resetObservables = () => {
-    this.state.ngOnDestroy();
     runInInjectionContext(
       this.injector,
       () => (this.state = new RxState<ProvidedValues>()),
diff --git a/apps/demos/src/app/shared/viewport.service.ts b/apps/demos/src/app/shared/viewport.service.ts
@@ -1,5 +1,9 @@
-import { BreakpointObserver, Breakpoints, BreakpointState } from '@angular/cdk/layout';
-import { Injectable, OnDestroy } from '@angular/core';
+import {
+  BreakpointObserver,
+  Breakpoints,
+  BreakpointState,
+} from '@angular/cdk/layout';
+import { Injectable } from '@angular/core';
 import { RxState } from '@rx-angular/state';
 import { distinctUntilChanged, map } from 'rxjs/operators';
 
@@ -20,7 +24,7 @@ interface ViewportServiceState {
 @Injectable({
   providedIn: 'root',
 })
-export class ViewportService implements OnDestroy {
+export class ViewportService {
   private readonly state = new RxState<ViewportServiceState>();
 
   readonly viewport$ = this.state.select('viewport');
@@ -52,15 +56,10 @@ export class ViewportService implements OnDestroy {
       );
     this.state.connect(viewport$, (oldState, viewportChange) => ({
       viewport: viewportChange,
-      isHandset:
-        viewportChange === 'mobile' || viewportChange === 'tablet',
+      isHandset: viewportChange === 'mobile' || viewportChange === 'tablet',
       isMobile: viewportChange === 'mobile',
       isTablet: viewportChange === 'tablet',
       isDesktop: viewportChange === 'desktop',
     }));
   }
-
-  ngOnDestroy() {
-    this.state.ngOnDestroy();
-  }
 }
