Minor refactoring

olegshan · olegshan · commit 12328b437e66 · 2016-11-29T01:16:11.000+02:00
diff --git a/src/main/java/com/olegshan/service/impl/JobServiceImpl.java b/src/main/java/com/olegshan/service/impl/JobServiceImpl.java
@@ -17,19 +17,22 @@
 public class JobServiceImpl implements JobService {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(JobServiceImpl.class);
+
     private JobRepository jobRepository;
+    private JTwitter twitter;
 
     @Autowired
-    public JobServiceImpl(JobRepository jobRepository) {
+    public JobServiceImpl(JobRepository jobRepository, JTwitter twitter) {
         this.jobRepository = jobRepository;
+        this.twitter = twitter;
     }
 
     public void save(Job job) {
         if (jobExists(job)) {
             update(job);
         } else {
             jobRepository.save(job);
-            JTwitter.tweet(job);
+            twitter.tweet(job);
             LOGGER.info("New job '{}' on {} found", job.getTitle(), job.getSource());
         }
     }
@@ -44,7 +47,7 @@ private void update(Job job) {
         LocalDate jobDate = job.getDate().toLocalDate();
         if (!jobFromDbDate.equals(jobDate)) {
             jobRepository.save(job);
-            JTwitter.tweet(job);
+            twitter.tweet(job);
             LOGGER.info("Job '{}', {} updated", job.getTitle(), job.getUrl());
         }
     }
diff --git a/src/main/java/com/olegshan/social/JTwitter.java b/src/main/java/com/olegshan/social/JTwitter.java
@@ -3,18 +3,23 @@
 import com.olegshan.entity.Job;
 import org.springframework.social.twitter.api.Twitter;
 import org.springframework.social.twitter.api.impl.TwitterTemplate;
+import org.springframework.stereotype.Component;
 
+@Component
 public class JTwitter {
 
     private static final String CONSUMER_KEY = System.getProperty("CKjP");
     private static final String CONSUMER_SECRET = System.getProperty("CSjP");
     private static final String ACCESS_TOKEN = System.getProperty("ATjP");
     private static final String ACCESS_TOKEN_SECRET = System.getProperty("ATSjP");
 
-    private static Twitter twitter = new TwitterTemplate(
-            CONSUMER_KEY, CONSUMER_SECRET, ACCESS_TOKEN, ACCESS_TOKEN_SECRET);
+    private Twitter twitter;
 
-    public static void tweet(Job job) {
+    public JTwitter() {
+        twitter = new TwitterTemplate(CONSUMER_KEY, CONSUMER_SECRET, ACCESS_TOKEN, ACCESS_TOKEN_SECRET);
+    }
+
+    public void tweet(Job job) {
         twitter.timelineOperations().updateStatus(job.getTitle() + " " + job.getUrl()
                 + " More jobs here: http://jparser.info");
     }
