fix(eslint-plugin): [prefer-regexp-exec] skip malformed regexes (typescript-eslint#6935)

yassin-kammoun-sonarsource · web-flow · commit 05ed60e25f1d · 2023-04-19T09:33:15.000-04:00
Skip malformed regular expressions
diff --git a/packages/eslint-plugin/src/rules/prefer-regexp-exec.ts b/packages/eslint-plugin/src/rules/prefer-regexp-exec.ts
@@ -125,7 +125,12 @@ export default createRule({
           argumentNode.type === AST_NODE_TYPES.Literal &&
           typeof argumentNode.value === 'string'
         ) {
-          const regExp = RegExp(argumentNode.value);
+          let regExp: RegExp;
+          try {
+            regExp = RegExp(argumentNode.value);
+          } catch {
+            return;
+          }
           return context.report({
             node: memberNode.property,
             messageId: 'regExpExecOverStringMatch',
diff --git a/packages/eslint-plugin/tests/rules/prefer-regexp-exec.test.ts b/packages/eslint-plugin/tests/rules/prefer-regexp-exec.test.ts
@@ -74,6 +74,12 @@ const matchCount = (str: string, re: RegExp) => {
   return (str.match(re) || []).length;
 };
     `,
+    // https://github.com/typescript-eslint/typescript-eslint/issues/6928
+    `
+function test(str: string) {
+  str.match('[a-z');
+}
+    `,
   ],
   invalid: [
     {
