bug symfony#11601 [Validator] Allow basic auth in url when using UrlValidator. (blaugueux)

fabpot · fabpot · commit 64543909f88c · 2014-08-09T12:41:29.000+02:00
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes symfony#11601). Discussion ---------- [Validator] Allow basic auth in url when using UrlValidator. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Now an url with basic auth like ```http://username:password@symfony.com``` can be valid. Commits ------- f1ea987 Allow basic auth in url. Improve regex. Add tests.
diff --git a/src/Symfony/Component/Validator/Constraints/UrlValidator.php b/src/Symfony/Component/Validator/Constraints/UrlValidator.php
@@ -24,6 +24,7 @@ class UrlValidator extends ConstraintValidator
 {
     const PATTERN = '~^
             (%s)://                                 # protocol
+            (([\pL\pN-]+:)?([\pL\pN-]+)@)?          # basic auth
             (
                 ([\pL\pN\pS-\.])+(\.?([\pL]|xn\-\-[\pL\pN-]+)+\.?) # a domain name
                     |                                              # or
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/UrlValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/UrlValidatorTest.php
@@ -116,6 +116,8 @@ public function getValidUrls()
             array('http://xn--espaa-rta.xn--ca-ol-fsay5a/'),
             array('http://xn--d1abbgf6aiiy.xn--p1ai/'),
             array('http://☎.com/'),
+            array('http://username:password@symfony.com'),
+            array('http://user-name@symfony.com'),
         );
     }
 
@@ -155,6 +157,10 @@ public function getInvalidUrls()
             array('ftp://[::1]/'),
             array('http://[::1'),
             array('http://hello.☎/'),
+            array('http://:password@symfony.com'),
+            array('http://:password@@symfony.com'),
+            array('http://username:passwordsymfony.com'),
+            array('http://usern@me:password@symfony.com'),
         );
     }
 

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ class UrlValidator extends ConstraintValidator`
`24`	`24`	`{`
`25`	`25`	`const PATTERN = '~^`
`26`	`26`	`(%s):// # protocol`
	`27`	`+ (([\pL\pN-]+:)?([\pL\pN-]+)@)? # basic auth`
`27`	`28`	`(`
`28`	`29`	`([\pL\pN\pS-\.])+(\.?([\pL]\|xn\-\-[\pL\pN-]+)+\.?) # a domain name`
`29`	`30`	`\| # or`