MNT fix typo and internal documentation in LinearModelLoss and Newton solver (#32039)

lorentzenchr · ogrisel · web-flow · commit 0eba4d410bcc · 2025-08-28T21:10:37.000Z
Co-authored-by: Olivier Grisel &lt;olivier.grisel@ensta.org&gt;
diff --git a/sklearn/linear_model/_glm/_newton_solver.py b/sklearn/linear_model/_glm/_newton_solver.py
@@ -610,7 +610,7 @@ def inner_solve(self, X, y, sample_weight):
             # Instead, we resort to lbfgs.
             if self.verbose:
                 print(
-                    "  The inner solver stumbled upon an singular or ill-conditioned "
+                    "  The inner solver stumbled upon a singular or ill-conditioned "
                     "Hessian matrix and resorts to LBFGS instead."
                 )
             self.use_fallback_lbfgs_solve = True
diff --git a/sklearn/linear_model/_linear_loss.py b/sklearn/linear_model/_linear_loss.py
@@ -31,7 +31,7 @@ def sandwich_dot(X, W):
         )
     else:
         # np.einsum may use less memory but the following, using BLAS matrix
-        # multiplication (gemm), is by far faster.
+        # multiplication (GEMM), is by far faster.
         WX = W[:, None] * X
         return X.T @ WX
 
@@ -71,7 +71,7 @@ class LinearModelLoss:
             if coef.shape (n_classes, n_dof):
                 intercept = coef[:, -1]
             if coef.shape (n_classes * n_dof,)
-                intercept = coef[n_features::n_dof] = coef[(n_dof-1)::n_dof]
+                intercept = coef[n_classes * n_features:] = coef[(n_dof-1):]
             intercept.shape = (n_classes,)
         else:
             intercept = coef[-1]
@@ -85,7 +85,8 @@ class LinearModelLoss:
         else:
             hessian.shape = (n_dof, n_dof)
 
-    Note: If coef has shape (n_classes * n_dof,), the 2d-array can be reconstructed as
+    Note: if coef has shape (n_classes * n_dof,), the classes are expected to be
+    contiguous, i.e. the 2d-array can be reconstructed as
 
         coef.reshape((n_classes, -1), order="F")
 

Original file line number	Diff line number	Diff line change
`@@ -610,7 +610,7 @@ def inner_solve(self, X, y, sample_weight):`
`610`	`610`	`# Instead, we resort to lbfgs.`
`611`	`611`	`if self.verbose:`
`612`	`612`	`print(`
`613`		`- " The inner solver stumbled upon an singular or ill-conditioned "`
	`613`	`+ " The inner solver stumbled upon a singular or ill-conditioned "`
`614`	`614`	`"Hessian matrix and resorts to LBFGS instead."`
`615`	`615`	`)`
`616`	`616`	`self.use_fallback_lbfgs_solve = True`