-
-
Notifications
You must be signed in to change notification settings - Fork 26.1k
Closed
Labels
Needs DecisionRequires decisionRequires decision
Description
Describe the bug
The wheels currently include tests and test data. These usually are of no additional value outside of the source distributions and thus just bloat the distribution and complicate reviews. For this reasons, I recommend excluding them from future wheels.
This matches the official recommendation for Python packaging as well (see https://packaging.python.org/en/latest/discussions/package-formats/#what-is-a-wheel):
Wheels are meant to contain exactly what is to be installed, and nothing more. In particular, wheels should never include tests and documentation, while sdists commonly do.
Steps/Code to Reproduce
Download the current wheels and look for sklearn/datasets/tests
Expected Results
The directory is absent.
Actual Results
The directory exists.
Versions
1.6.1
Metadata
Metadata
Assignees
Labels
Needs DecisionRequires decisionRequires decision