DOC Use from_cv_results in plot_roc_crossval.py
#31455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturoAmorQ
approved these changes
May 30, 2025
There was a problem hiding this comment.
Thanks @lucyleeow, LGTM! But I think it's worth adding a short sentence highlighting that we plot the RocCurveDisplay using the precomputed cv_results.
|
Thanks @ArturoAmorQ ! Done, hopefully it reads okay. |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 15, 2025
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 16, 2025
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 16, 2025
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 16, 2025
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow up to #30399
What does this implement/fix? Explain your changes.
I have only made code changes to use
from_cv_results(the plot should look exactly the same). I am conscious there is a very nice PR improving that example here #29611, so I did not want to change the text / alter the plot. Sorry for the merge conflicts @ArturoAmorQ (I would be happy to fix them if that helps)cc @glemaitre
Any other comments?