Skip to content

Commit 29b5174

Browse files
committed
Update methods.
1 parent 7e7bccc commit 29b5174

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

core/src/main/java/com/github/api/v2/services/impl/RepositoryServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ public void unwatchRepository(String userName, String repositoryName) {
342342
@Override
343343
public void updateRepository(Repository repository) {
344344
GitHubApiUrlBuilder builder = createGitHubApiUrlBuilder(GitHubApiUrls.RepositoryApiUrls.UPDATE_REPOSITORY_URL);
345-
String apiUrl = builder.withField(ParameterNames.USER_NAME, "").withField(ParameterNames.REPOSITORY_NAME, "").buildUrl();
345+
String apiUrl = builder.withField(ParameterNames.USER_NAME, repository.getOwner()).withField(ParameterNames.REPOSITORY_NAME, repository.getName()).buildUrl();
346346
Map<String, String> parameters = new HashMap<String, String>();
347347
parameters.put("values[" + ParameterNames.DESCRIPTION + "]", repository.getDescription());
348348
parameters.put("values[" + ParameterNames.HOME_PAGE + "]", repository.getHomepage());

core/src/main/java/com/github/api/v2/services/impl/UserServiceImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,8 @@ public void unfollowUser(String userName) {
219219
@Override
220220
public void updateUser(User user) {
221221
GitHubApiUrlBuilder builder = createGitHubApiUrlBuilder(GitHubApiUrls.UserApiUrls.UPDATE_USER_URL);
222-
String apiUrl = builder.withField(ParameterNames.USER_NAME, user.getUsername()).buildUrl();
222+
String userName = (user.getUsername() == null) ? user.getLogin() : user.getUsername();
223+
String apiUrl = builder.withField(ParameterNames.USER_NAME, userName).buildUrl();
223224
Map<String, String> parameters = new HashMap<String, String>();
224225
parameters.put("values[" + ParameterNames.NAME + "]", user.getName());
225226
parameters.put("values[" + ParameterNames.EMAIL + "]", user.getEmail());

core/src/test/resources/com/github/api/v2/services/constant/TestConstants.properties

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
# Authentication Parameters
2-
com.github.api.v2.services.clientId=18790e7033ab0148f05c
3-
com.github.api.v2.services.clientSecret=52695c3febf1721b8bc6f569c5210d38d043696c
2+
com.github.api.v2.services.clientId=
3+
com.github.api.v2.services.clientSecret=
44
com.github.api.v2.services.code=
5-
com.github.api.v2.services.accessToken=c53ac3e9a36285125f9e1da0726a1a53808ac1f1
6-
com.github.api.v2.services.callbackUrl=http://waveclipse.appspot.com/Main
5+
com.github.api.v2.services.accessToken=
6+
com.github.api.v2.services.callbackUrl=
77

8-
com.github.api.v2.services.apiKey=5842ac9d1fb8ce4f7a5f0effd414e11d
8+
com.github.api.v2.services.apiKey=
99
com.github.api.v2.services.referrer=http://github.com/nabeelmukhtar/github-java-sdk
1010
com.github.api.v2.services.testQuery=java
1111
com.github.api.v2.services.testUserName=githubapitest

github-api.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,4 +50,5 @@ API Design
5050
Android Configuration
5151

5252

53-
53+
Add github-java-sdk to the list of Github libraries.
54+
I have created a Java library for GitHub API and added it to the libaries page. You can pull the changes from http://github.com/nabeelmukhtar/develop.github.com.

0 commit comments

Comments
 (0)