Skip to content

Commit 9819855

Browse files
iluwatariluwatar
committed
Code cleanup
1 parent 5381387 commit 9819855

File tree

243 files changed

+1157
-1166
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

243 files changed

+1157
-1166
lines changed

‎abstract-document/src/test/java/com/iluwatar/abstractdocument/AbstractDocumentTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ private class DocumentImplementation extends AbstractDocument {
4747
}
4848
}
4949

50-
private DocumentImplementation document = new DocumentImplementation(new HashMap<>());
50+
private final DocumentImplementation document = new DocumentImplementation(new HashMap<>());
5151

5252
@Test
5353
public void shouldPutAndGetValue() {

‎abstract-factory/src/test/java/com/iluwatar/abstractfactory/AbstractFactoryTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
*/
3737
public class AbstractFactoryTest {
3838

39-
private App app = new App();
39+
private final App app = new App();
4040
private KingdomFactory elfFactory;
4141
private KingdomFactory orcFactory;
4242

‎acyclic-visitor/src/test/java/com/iluwatar/acyclicvisitor/ConfigureForDosVisitorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
*/
3838
public class ConfigureForDosVisitorTest {
3939

40-
private TestLogger logger = TestLoggerFactory.getTestLogger(ConfigureForDosVisitor.class);
40+
private final TestLogger logger = TestLoggerFactory.getTestLogger(ConfigureForDosVisitor.class);
4141

4242
@Test
4343
public void testVisitForZoom() {

‎adapter/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ And captain expects an implementation of `RowingBoat` interface to be able to mo
5656
```java
5757
public class Captain {
5858

59-
private RowingBoat rowingBoat;
59+
private final RowingBoat rowingBoat;
6060
// default constructor and setter for rowingBoat
6161
public Captain(RowingBoat rowingBoat) {
6262
this.rowingBoat = rowingBoat;
@@ -75,7 +75,7 @@ public class FishingBoatAdapter implements RowingBoat {
7575

7676
private static final Logger LOGGER = LoggerFactory.getLogger(FishingBoatAdapter.class);
7777

78-
private FishingBoat boat;
78+
private final FishingBoat boat;
7979

8080
public FishingBoatAdapter() {
8181
boat = new FishingBoat();

‎adapter/src/main/java/com/iluwatar/adapter/FishingBoatAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
*/
3030
public class FishingBoatAdapter implements RowingBoat {
3131

32-
private FishingBoat boat;
32+
private final FishingBoat boat;
3333

3434
public FishingBoatAdapter() {
3535
boat = new FishingBoat();

‎ambassador/src/test/java/com/iluwatar/ambassador/RemoteServiceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ void testSuccessfulCall() {
4848
}
4949

5050
private static class StaticRandomProvider implements RandomProvider {
51-
private double value;
51+
private final double value;
5252

5353
StaticRandomProvider(double value) {
5454
this.value = value;

‎async-method-invocation/src/main/java/com/iluwatar/async/method/invocation/ThreadAsyncExecutor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ private static class CompletableResult<T> implements AsyncResult<T> {
100100
void setValue(T value) {
101101
this.value = value;
102102
this.state = COMPLETED;
103-
this.callback.ifPresent(ac -> ac.onComplete(value, Optional.<Exception>empty()));
103+
this.callback.ifPresent(ac -> ac.onComplete(value, Optional.empty()));
104104
synchronized (lock) {
105105
lock.notifyAll();
106106
}

‎business-delegate/src/main/java/com/iluwatar/business/delegate/Client.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
*/
2929
public class Client {
3030

31-
private BusinessDelegate businessDelegate;
31+
private final BusinessDelegate businessDelegate;
3232

3333
public Client(BusinessDelegate businessDelegate) {
3434
this.businessDelegate = businessDelegate;

‎business-delegate/src/main/java/com/iluwatar/business/delegate/ServiceType.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,5 +28,5 @@
2828
*/
2929
public enum ServiceType {
3030

31-
EJB, JMS;
31+
EJB, JMS
3232
}

‎bytecode/src/main/java/com/iluwatar/bytecode/VirtualMachine.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@
3030
*/
3131
public class VirtualMachine {
3232

33-
private Stack<Integer> stack = new Stack<>();
33+
private final Stack<Integer> stack = new Stack<>();
3434

35-
private Wizard[] wizards = new Wizard[2];
35+
private final Wizard[] wizards = new Wizard[2];
3636

3737
/**
3838
* Constructor.

0 commit comments

Comments
 (0)