Core: Escape id/name before using it as a selector in errorsFor

jzaefferer · jzaefferer · commit 20f3e9fac929 · 2014-09-23T13:27:51.000+02:00
Fixes jquery-validation#1275
diff --git a/src/core.js b/src/core.js
@@ -807,9 +807,10 @@ $.extend( $.validator, {
 			var name = this.idOrName( element ),
 				describer = $( element ).attr( "aria-describedby" ),
 				selector = "label[for='" + name + "'], label[for='" + name + "'] *";
+
 			// aria-describedby should directly reference the error element
 			if ( describer ) {
-				selector = selector + ", #" + describer.replace( /\s+/g, ", #" );
+				selector = selector + ", #" + describer.replace( /[\[\]]/g, "\\$&" ).replace( /\s+/g, ", #" );
 			}
 			return this
 				.errors()
diff --git a/test/error-placement.js b/test/error-placement.js
@@ -331,3 +331,16 @@ test( "test pre-assigned non-error aria-describedby", function( assert ) {
 	strictEqual( "This is where you enter your data", $("#testForm17text-description").text() );
 	strictEqual( "", $("#testForm17text-error").text(), "Error label is empty for valid field" );
 });
+
+test( "test id/name containing brackets", function( assert ) {
+	var form = $( "#testForm18" ),
+		field = $( "#testForm18\\[text\\]" );
+
+	form.validate({
+		errorElement: "span"
+	});
+
+	form.valid();
+	field.valid();
+	assert.hasError( field, "required" );
+});
diff --git a/test/index.html b/test/index.html
@@ -173,6 +173,10 @@ <h2 id="qunit-userAgent"></h2>
 		<input name="testForm17text" id="testForm17text" data-rule-required="true" data-msg="required" aria-describedby="testForm17text-description">
 		<span id="testForm17text-description">This is where you enter your data</span>
 	</form>
+	<form id="testForm18">
+		<!-- test id/name containing brackets -->
+		<input name="testForm18[text]" id="testForm18[text]" required>
+	</form>
 	<form id="dataMessages">
 		<input name="dataMessagesName" id="dataMessagesName" class="required" data-msg-required="You must enter a value here">
 	</form>
