diff --git a/.github/workflows/clippy.yml b/.github/workflows/clippy.yml index b1aa0ec..0875727 100644 --- a/.github/workflows/clippy.yml +++ b/.github/workflows/clippy.yml @@ -32,7 +32,7 @@ jobs: with: profile: minimal toolchain: ${{ matrix.rust }} - override: true + override: true components: clippy - shell: bash run: | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 2d7bca6..40e3474 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -29,6 +29,9 @@ jobs: fail-fast: false # Even if one job fails we still want to see the other ones matrix: # 1.39 is MSRV. Keep in sync with Cargo.toml + # + # There are no MSRV guarentees for the kv_unstable feature. + # See `Cargo.toml` for more details. rust: [1.39, stable, nightly] # NOTE: Features to test must be specified manually. They are applied to all versions seperately. # @@ -37,6 +40,9 @@ jobs: # # Specific feature combos can be overriden per-version with 'include' and 'exclude' features: ["", "kv_unstable"] + exclude: + - rust: 1.39 # MSRV (see above) + features: "kv_unstable" steps: - uses: actions/checkout@v2 @@ -44,8 +50,14 @@ jobs: with: toolchain: ${{ matrix.rust }} override: true - # NOTE: We only run `cargo test`. No need for a seperate `cargo check` + - name: Check + run: | + cargo check --verbose --features "${{ matrix.features }}" + # A failing `cargo check` always fails the build + continue-on-error: false + # NOTE: We only run `cargo test` if version > MSRV. Tests break on old MSRV due to + # a dev-dependency. - name: Test run: | cargo test --verbose --features "${{ matrix.features }}" - + if: "${{ matrix.rust == 'stable' || matrix.rust == 'nightly' }}" diff --git a/Cargo.toml b/Cargo.toml index f85c146..9b5b576 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -21,7 +21,11 @@ edition = "2018" # # The first version of Cargo that supports this field was in Rust 1.56.0. # In older releases, the field will be ignored, and Cargo will display a warning. -rust-version = "1.39" +# +# DISCLAIMER: +# The log/kv_unstable feature requires a recent (stable) compiler. +# It will not compile with this claimed MSRV and requires a recent (stable) compiler. +rust-version = "1.38" [lib] path = "lib.rs" diff --git a/README.md b/README.md index 4a650f1..78d825b 100644 --- a/README.md +++ b/README.md @@ -11,8 +11,8 @@ slog-rs Gitter Chat - - Minimum Rust Version 1.38 + + Minimum Rust Version 1.38