Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jquery-validation/jquery-validation
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: slykar/jquery-validation
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Sep 20, 2013

  1. Problem with not running validation when onfocusout is called. 

    There is a problem with plugin not validating fields when focus is out. This was reported by some people to work on "random" basis.

The problem is on line 239. The check fails because `this.optional` returns string `"dependency-mismatch"` and the whole if statement returns wrong bool result. Sometimes it works, because the field is in `this.submited` array

The whole method `optional` should be probably changed.
This change fix problem for me, but I'm not sure about other use cases.

I'm not knee deep in the code.
    @slykar
    slykar committed Sep 20, 2013
    Configuration menu
    Copy the full SHA
    35c6811 View commit details
    Browse the repository at this point in the history

  2. onfocusout if statement preventing validation

    @slykar
    slykar committed Sep 20, 2013
    Configuration menu
    Copy the full SHA
    ea16df2 View commit details
    Browse the repository at this point in the history
Loading