Skip to content

Commit 155972b

Browse files
committed
Check headers first and let the CHECK_LIBRARY macro
handle checking for the library. This makes it correctly handle non-standard system paths as long as gcc knows about them. Should fix the build on Ubuntu natty.
1 parent c6ea819 commit 155972b

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

ext/gd/config.m4

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,11 @@ AC_DEFUN([PHP_GD_VPX],[
7777
if test "$PHP_VPX_DIR" != "no"; then
7878
7979
for i in $PHP_VPX_DIR /usr/local /usr; do
80-
test -f $i/$PHP_VPX_DIR/libvpx.$SHLIB_SUFFIX_NAME || test -f $i/$PHP_LIBDIR/libvpx.a && GD_VPX_DIR=$i && break
80+
test -f $i/include/vpx_codec.h || test -f $i/include/vpx/vpx_codec.h && GD_VPX_DIR=$i && break
8181
done
8282
8383
if test -z "$GD_VPX_DIR"; then
84-
AC_MSG_ERROR([libvpx.(a|so) not found.])
84+
AC_MSG_ERROR([vpx_codec.h not found.])
8585
fi
8686
8787
PHP_CHECK_LIBRARY(vpx,vpx_codec_destroy,
@@ -103,11 +103,11 @@ AC_DEFUN([PHP_GD_JPEG],[
103103
if test "$PHP_JPEG_DIR" != "no"; then
104104
105105
for i in $PHP_JPEG_DIR /usr/local /usr; do
106-
test -f $i/$PHP_LIBDIR/libjpeg.$SHLIB_SUFFIX_NAME || test -f $i/$PHP_LIBDIR/libjpeg.a && GD_JPEG_DIR=$i && break
106+
test -f $i/include/jpeglib.h && GD_JPEG_DIR=$i && break
107107
done
108108
109109
if test -z "$GD_JPEG_DIR"; then
110-
AC_MSG_ERROR([libjpeg.(a|so) not found.])
110+
AC_MSG_ERROR([jpeglib.h not found.])
111111
fi
112112
113113
PHP_CHECK_LIBRARY(jpeg,jpeg_read_header,
@@ -128,21 +128,17 @@ AC_DEFUN([PHP_GD_PNG],[
128128
if test "$PHP_PNG_DIR" != "no"; then
129129
130130
for i in $PHP_PNG_DIR /usr/local /usr; do
131-
test -f $i/$PHP_LIBDIR/libpng.$SHLIB_SUFFIX_NAME || test -f $i/$PHP_LIBDIR/libpng.a && GD_PNG_DIR=$i && break
131+
test -f $i/include/png.h && GD_PNG_DIR=$i && break
132132
done
133133
134134
if test -z "$GD_PNG_DIR"; then
135-
AC_MSG_ERROR([libpng.(a|so) not found.])
135+
AC_MSG_ERROR([png.h not found.])
136136
fi
137137
138138
if test "$PHP_ZLIB_DIR" = "no"; then
139139
AC_MSG_ERROR([PNG support requires ZLIB. Use --with-zlib-dir=<DIR>])
140140
fi
141141
142-
if test ! -f $GD_PNG_DIR/include/png.h; then
143-
AC_MSG_ERROR([png.h not found.])
144-
fi
145-
146142
PHP_CHECK_LIBRARY(png,png_write_image,
147143
[
148144
PHP_ADD_INCLUDE($GD_PNG_DIR/include)

0 commit comments

Comments
 (0)