Don't catch any exceptions in the QR code generator function

cyrozap · cyrozap · commit 787e8ebe4e46 · 2015-03-22T03:33:20.000-04:00
diff --git a/setup.py b/setup.py
@@ -6,7 +6,7 @@
 
 setup(
     name='python-vipaccess',
-    version='0.1.2',
+    version='0.1.3',
     description="A free software implementation of Symantec's VIP Access application and protocol",
     long_description=readme,
     url='https://github.com/cyrozap/python-vipaccess',
diff --git a/vipaccess/utils.py b/vipaccess/utils.py
@@ -225,19 +225,16 @@ def generate_otp_uri(token_id, secret):
 
 def generate_qr_code(uri):
     '''Generate a QR code from the OTP URI.'''
-    try:
-        qr = qrcode.QRCode(
-            version=1,
-            error_correction=qrcode.constants.ERROR_CORRECT_L,
-            box_size=10,
-            border=4
-            )
-        qr.add_data(uri)
-        qr.make(fit=True)
-        im = qr.make_image()
-        return im
-    except:
-        return False
+    qr = qrcode.QRCode(
+        version=1,
+        error_correction=qrcode.constants.ERROR_CORRECT_L,
+        box_size=10,
+        border=4
+        )
+    qr.add_data(uri)
+    qr.make(fit=True)
+    im = qr.make_image()
+    return im
 
 def check_token(token_id, secret):
     '''Check the validity of the generated token.'''
