Skip to content

Commit bbdf8e5

Browse files
committed
1. adjust server side's long polling timeout from 30 seconds to 60 seconds
2. adjust client side's long polling timeout from 600 seconds to 90 seconds
1 parent 92ee12c commit bbdf8e5

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

apollo-client/src/main/java/com/ctrip/framework/apollo/internals/RemoteConfigLongPollService.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ public class RemoteConfigLongPollService {
5454
private static final Joiner.MapJoiner MAP_JOINER = Joiner.on("&").withKeyValueSeparator("=");
5555
private static final Escaper queryParamEscaper = UrlEscapers.urlFormParameterEscaper();
5656
private static final long INIT_NOTIFICATION_ID = ConfigConsts.NOTIFICATION_ID_PLACEHOLDER;
57+
//90 seconds, should be longer than server side's long polling timeout, which is now 60 seconds
58+
private static final int LONG_POLLING_READ_TIMEOUT = 90 * 1000;
5759
private final ExecutorService m_longPollingService;
5860
private final AtomicBoolean m_longPollingStopped;
5961
private SchedulePolicy m_longPollFailSchedulePolicyInSecond;
@@ -161,8 +163,7 @@ private void doLongPollingRefresh(String appId, String cluster, String dataCente
161163

162164
logger.debug("Long polling from {}", url);
163165
HttpRequest request = new HttpRequest(url);
164-
//longer timeout for read - 10 minutes
165-
request.setReadTimeout(600000);
166+
request.setReadTimeout(LONG_POLLING_READ_TIMEOUT);
166167

167168
transaction.addData("Url", url);
168169

apollo-configservice/src/main/java/com/ctrip/framework/apollo/configservice/wrapper/DeferredResultWrapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
* @author Jason Song(song_s@ctrip.com)
1818
*/
1919
public class DeferredResultWrapper {
20-
private static final long TIMEOUT = 30 * 1000;//30 seconds
20+
private static final long TIMEOUT = 60 * 1000;//60 seconds
2121
private static final ResponseEntity<List<ApolloConfigNotification>>
2222
NOT_MODIFIED_RESPONSE_LIST = new ResponseEntity<>(HttpStatus.NOT_MODIFIED);
2323

0 commit comments

Comments
 (0)