Fixed EIP-712 getPayload dropping EIP712Domain from types for JSON-RPC calls (ethers-io#687).

ricmoo · ricmoo · commit d3b1ac046aaf · 2020-12-08T01:37:44.000-05:00
diff --git a/packages/hash/src.ts/typed-data.ts b/packages/hash/src.ts/typed-data.ts
@@ -463,6 +463,8 @@ export class TypedDataEncoder {
 
         const typesWithDomain = shallowCopy(types);
         if (typesWithDomain.EIP712Domain) {
+            logger.throwArgumentError("types must not contain EIP712Domain type", "types.EIP712Domain", types);
+        } else {
             typesWithDomain.EIP712Domain = domainTypes;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -463,6 +463,8 @@ export class TypedDataEncoder {`
`463`	`463`
`464`	`464`	`const typesWithDomain = shallowCopy(types);`
`465`	`465`	`if (typesWithDomain.EIP712Domain) {`
	`466`	`+ logger.throwArgumentError("types must not contain EIP712Domain type", "types.EIP712Domain", types);`
	`467`	`+ } else {`
`466`	`468`	`typesWithDomain.EIP712Domain = domainTypes;`
`467`	`469`	`}`
`468`	`470`