Skip to content

Commit 68e70bf

Browse files
committed
Reword this comment
1 parent aa2e3a5 commit 68e70bf

File tree

1 file changed

+17
-16
lines changed

1 file changed

+17
-16
lines changed

src/output/details.rs

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -203,23 +203,24 @@ impl<'a> Render<'a> {
203203
// There are three “levels” of extended attribute support:
204204
//
205205
// 1. If we’re compiling without that feature, then
206-
// exa pretends no files have attributes.
207-
// 2. If the feature is enabled but the --extended flag
208-
// hasn’t been specified, then display an @ in the
209-
// permissions column for files with xattrs, but don’t
210-
// display anything else.
211-
// 3. If the --extended flag *has* been specified, then
212-
// display the @, the attributes and their lengths,
213-
// and any errors encountered when getting them.
206+
// exa pretends all files have no attributes.
207+
// 2. If the feature is enabled and the --extended flag
208+
// has been specified, then display an @ in the
209+
// permissions column for files with attributes, the
210+
// names of all attributes and their lengths, and any
211+
// errors encountered when getting them.
212+
// 3. If the --extended flag *hasn’t* been specified, then
213+
// display the @, but don’t display anything else.
214214
//
215-
// For a while, exa took a stricter approach to (2): if
216-
// an error occurred while checking a file’s xattrs, exa
217-
// would display that error even though the attributes
218-
// weren’t actually being shown! This was confusing, as
219-
// users were being shown errors for something they didn’t
220-
// explicitly ask for, and just cluttered up the output.
221-
// So now errors aren’t printed unless the user passes
222-
// --extended to signify that they want to see them.
215+
// For a while, exa took a stricter approach to (3):
216+
// if an error occurred while checking a file’s xattrs to
217+
// see if it should display the @, exa would display that
218+
// error even though the attributes weren’t actually being
219+
// shown! This was confusing, as users were being shown
220+
// errors for something they didn’t explicitly ask for,
221+
// and just cluttered up the output. So now errors aren’t
222+
// printed unless the user passes --extended to signify
223+
// that they want to see them.
223224

224225
if xattr::ENABLED {
225226
match file.path.attributes() {

0 commit comments

Comments
 (0)