Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/symfony
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7.4
Choose a base ref
...
head repository: symfony/symfony
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.4
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Aug 14, 2025

  1. [Process] Enhance hasSystemCallBeenInterrupted function for non-engli… 

    …sh locale
    @christianseel @nicolas-grekas
    christianseel authored and nicolas-grekas committed Aug 14, 2025
    Configuration menu
    Copy the full SHA
    013126d View commit details
    Browse the repository at this point in the history

  2. bug #61401 [Process] Enhance hasSystemCallBeenInterrupted function fo… 

    …r non-english locale (christianseel)

This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[Process] Enhance hasSystemCallBeenInterrupted function for non-english locale

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Related: PHPMailer/PHPMailer#3183
| License       | MIT

We've been facing an issue with PHPMailer (PHPMailer/PHPMailer#3183) where `stream_select()` returns false, but because our application uses `setlocale(LC_ALL, 'de_DE.UTF-8')`, the PHP warning does **NOT** contain the string `'interrupted system call'` which results in unexpected behavior (no retry happening).

We did found a fix for this: PHPMailer/PHPMailer#3193

> I received a great hint by `@teefax` – who pointed out that the stream_select(): Unable to select part of the php warning message is not translated for other locales. Only the interrupted system call part is translated.
>
> That Unable to select is followed by an error number in square brackets. However that number can be different based on the operating system of the server. But PHP has a constant [SOCKET_EINTR](https://www.php.net/manual/en/sockets.constants.php#constant.socket-eintr) for that.
>
> So the recommendation is to check for the SOCKET_EINTR constant which is defined under Windows and UNIX-like platforms (if available on the platform) and use that with the other english warning text to catch those interrupted system calls for non-english locale applications.
>
> I left the existing check to avoid any potential unknown breaking change and extended the if-condition.

As I known Symfony was using a similar approach, I'm recommending to apply this enhancement to the "interrupted check" as well.

Commits
-------

013126d [Process] Enhance hasSystemCallBeenInterrupted function for non-english locale
    @nicolas-grekas
    nicolas-grekas committed Aug 14, 2025
    Configuration menu
    Copy the full SHA
    b0687c9 View commit details
    Browse the repository at this point in the history
Loading