-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: symfony/symfony
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7.4
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: symfony/symfony
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.4
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 6 commits
- 10 files changed
- 3 contributors
Commits on Jun 12, 2025
-
Configuration menu - View commit details
-
Copy full SHA for d39a7ac - Browse repository at this point
Copy the full SHA d39a7acView commit details
Commits on Jun 13, 2025
-
bug #60771 [Runtime] fix compatibility with Symfony 7.4 (xabbuh)
This PR was merged into the 6.4 branch. Discussion ---------- [Runtime] fix compatibility with Symfony 7.4 | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Since #60394 using `add()` is deprecated. This means that our tests can trigger deprecations on older branches when the high deps job is run. This usually is not an issue as we silence them with the `SYMFONY_DEPRECATIONS_HELPER` env var. However, phpt tests are run in a child process where the deprecation error handler of the PHPUnit bridge doesn't step in. Thus, for them deprecations are not silenced leading to failures. We did something similar before in #60376. Commits ------- d39a7ac fix compatibility with Symfony 7.4
Configuration menu - View commit details
-
Copy full SHA for c69e4ab - Browse repository at this point
Copy the full SHA c69e4abView commit details -
Configuration menu - View commit details
-
Copy full SHA for df064b0 - Browse repository at this point
Copy the full SHA df064b0View commit details -
bug #60502 [HttpCache] Hit the backend only once after waiting for th…
…e cache lock (mpdude) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [HttpCache] Hit the backend only once after waiting for the cache lock | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT When the `HttpCache` has to wait for a lock held by another, concurrent process, the `lock()` method wants to make sure we continue operation based on the most recent cache entry, possibly updated by the concurrent process. So, after waiting for lock release, it calls `lookup()` to obtain this cache entry. This is, in fact, a reentrant call up into the current call stack. Having `lookup()` multiple times on the call stack opens up a way to call the backend for validation multiple times. I have observed this in practice at least in combination with the `no-cache` cache-control header, causing surprising side effects™️ ✨. Also without `no-cache` you can get strange-looking cache traces like `stale, valid, store, fresh`. Those occur only when concurrent locking is a issue. I am not super happy with using an exception for a control flow issue like this. But, rolling back to `lookup` seems to be the most sensible decision for me, and using special return values to indicate this condition isn't really pretty either. Commits ------- df064b0 [HttpCache] Hit the backend only once after waiting for the cache lock
Configuration menu - View commit details
-
Copy full SHA for aaa67ea - Browse repository at this point
Copy the full SHA aaa67eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f21b2f4 - Browse repository at this point
Copy the full SHA f21b2f4View commit details -
bug #60779 Silence E_DEPRECATED and E_USER_DEPRECATED (nicolas-grekas)
This PR was merged into the 6.4 branch. Discussion ---------- Silence E_DEPRECATED and E_USER_DEPRECATED | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #60528 | License | MIT This change works around php/php-src#17422 This shouldn't change much in practice because we report both not-silenced and silenced deprecations, except for the case when the native php error handler is triggered, which is what happens at this opcache stage, see php/php-src#18541 also. Commits ------- f21b2f4 Silence E_DEPRECATED and E_USER_DEPRECATED
Configuration menu - View commit details
-
Copy full SHA for 9a7f7a3 - Browse repository at this point
Copy the full SHA 9a7f7a3View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 7.4...6.4