From 5b2634ff8c7da371c04338953172847fc81cfb2c Mon Sep 17 00:00:00 2001
From: maciekpaprocki <maciekpaprocki@gmail.com>
Date: Tue, 20 May 2025 11:29:20 +0100
Subject: [PATCH] added earlier skip to allow if=false when using source
 mapping

---
 src/Symfony/Component/ObjectMapper/ObjectMapper.php         | 6 +++---
 .../Tests/Fixtures/HydrateObject/SourceOnly.php             | 6 ++++--
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/Symfony/Component/ObjectMapper/ObjectMapper.php b/src/Symfony/Component/ObjectMapper/ObjectMapper.php
index 7624a05f7bfe0..d78bc3ce8d216 100644
--- a/src/Symfony/Component/ObjectMapper/ObjectMapper.php
+++ b/src/Symfony/Component/ObjectMapper/ObjectMapper.php
@@ -122,12 +122,12 @@ public function map(object $source, object|string|null $target = null): object
                     $sourcePropertyName = $mapping->source;
                 }
 
-                $value = $this->getRawValue($source, $sourcePropertyName);
-                if (($if = $mapping->if) && ($fn = $this->getCallable($if, $this->conditionCallableLocator)) && !$this->call($fn, $value, $source, $mappedTarget)) {
+                if (false === $if = $mapping->if) {
                     continue;
                 }
 
-                if (false === $if) {
+                $value = $this->getRawValue($source, $sourcePropertyName);
+                if ($if && ($fn = $this->getCallable($if, $this->conditionCallableLocator)) && !$this->call($fn, $value, $source, $mappedTarget)) {
                     continue;
                 }
 
diff --git a/src/Symfony/Component/ObjectMapper/Tests/Fixtures/HydrateObject/SourceOnly.php b/src/Symfony/Component/ObjectMapper/Tests/Fixtures/HydrateObject/SourceOnly.php
index 9e3127b80d965..c062427c6e8d0 100644
--- a/src/Symfony/Component/ObjectMapper/Tests/Fixtures/HydrateObject/SourceOnly.php
+++ b/src/Symfony/Component/ObjectMapper/Tests/Fixtures/HydrateObject/SourceOnly.php
@@ -15,7 +15,9 @@
 
 class SourceOnly
 {
-    public function __construct(#[Map(source: 'name')] public string $mappedName)
-    {
+    public function __construct(
+        #[Map(source: 'name')] public string $mappedName,
+        #[Map(if: false)] public ?string $mappedDescription = null
+    ) {
     }
 }