From 21f202641e1e89cf3d851a3aaa2ee8ed2b508166 Mon Sep 17 00:00:00 2001 From: Makar Date: Wed, 30 Jul 2025 13:46:17 +0300 Subject: [PATCH 1/2] feat: Expand LockableTrait API --- src/Symfony/Component/Console/Command/LockableTrait.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/Console/Command/LockableTrait.php b/src/Symfony/Component/Console/Command/LockableTrait.php index b7abd2fdc589..8c09a680aab1 100644 --- a/src/Symfony/Component/Console/Command/LockableTrait.php +++ b/src/Symfony/Component/Console/Command/LockableTrait.php @@ -32,7 +32,7 @@ trait LockableTrait /** * Locks a command. */ - private function lock(?string $name = null, bool $blocking = false): bool + private function lock(?string $name = null, bool $blocking = false, float $ttl = 300.0, bool $authRelease = true): bool { if (!class_exists(SemaphoreStore::class)) { throw new LogicException('To enable the locking feature you must install the symfony/lock component. Try running "composer require symfony/lock".'); @@ -62,7 +62,7 @@ private function lock(?string $name = null, bool $blocking = false): bool } } - $this->lock = $this->lockFactory->createLock($name); + $this->lock = $this->lockFactory->createLock($name, $ttl, $authRelease); if (!$this->lock->acquire($blocking)) { $this->lock = null; From 65281627ce7b91e669fc1f110d9402de912ff66c Mon Sep 17 00:00:00 2001 From: Makar Date: Wed, 30 Jul 2025 14:03:36 +0300 Subject: [PATCH 2/2] fix: Fix parameter name --- src/Symfony/Component/Console/Command/LockableTrait.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/Console/Command/LockableTrait.php b/src/Symfony/Component/Console/Command/LockableTrait.php index 8c09a680aab1..beaade2dc166 100644 --- a/src/Symfony/Component/Console/Command/LockableTrait.php +++ b/src/Symfony/Component/Console/Command/LockableTrait.php @@ -32,7 +32,7 @@ trait LockableTrait /** * Locks a command. */ - private function lock(?string $name = null, bool $blocking = false, float $ttl = 300.0, bool $authRelease = true): bool + private function lock(?string $name = null, bool $blocking = false, float $ttl = 300.0, bool $autoRelease = true): bool { if (!class_exists(SemaphoreStore::class)) { throw new LogicException('To enable the locking feature you must install the symfony/lock component. Try running "composer require symfony/lock".'); @@ -62,7 +62,7 @@ private function lock(?string $name = null, bool $blocking = false, float $ttl = } } - $this->lock = $this->lockFactory->createLock($name, $ttl, $authRelease); + $this->lock = $this->lockFactory->createLock($name, $ttl, $autoRelease); if (!$this->lock->acquire($blocking)) { $this->lock = null;