-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[Intl] Add methods to filter currencies more precisely #61431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Crovitche-1623
wants to merge
16
commits into
symfony:7.4
Choose a base branch
from
Crovitche-1623:currencies-methods
base: 7.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,596
−0
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f038af2
test: add test for `isActive method`
Crovitche-1623 1276849
feat: add required metadata in the generated data
Crovitche-1623 62312ed
feat: add `isActive` method
Crovitche-1623 449afd2
refactor: cs
Crovitche-1623 c7719cc
docs: updated CHANGELOG.md
Crovitche-1623 8d96d1c
docs: fix grammar and consistency in currency notes
Crovitche-1623 ab6e0f1
fix: incorrect metadata for `from` and `to` properties
Crovitche-1623 6ee933d
feat: refactor according to comments + multiple parameters to cover a…
Crovitche-1623 0f4e203
feat: changes related to the review + cs
Crovitche-1623 88a1d63
test: fix testForCountry expected result
Crovitche-1623 ada1273
refactor: cs
Crovitche-1623 ed4d258
bug: fix condition in isValidInCountry
Crovitche-1623 6ad12f4
test: added few tests for CurrenciesTest.php
Crovitche-1623 5c86572
test: added few tests for CurrenciesTest.php
Crovitche-1623 95632e9
docs: updated `CHANGELOG.md`
Crovitche-1623 b2b7eeb
test: fix incorrect return type for `forCountry` and covered all use …
Crovitche-1623 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just
foreach ($supplementalDataBundle['CurrencyMap']
?