Skip to content

Commit e816bb5

Browse files
author
Stewart Miles
committed
Integrate Latest @ 118726261
Changes to messaging/testapp ... - Making the iOS implementation of Initialization run on the main thread. CL: 118726261
1 parent 4dc0541 commit e816bb5

File tree

4 files changed

+6
-8
lines changed

4 files changed

+6
-8
lines changed

messaging/testapp/AndroidManifest.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
3-
package="com.google.firebase.codelab.friendlychat"
3+
package="com.google.android.messaging.testapp"
44
android:versionCode="1"
55
android:versionName="1.0">
66
<uses-sdk android:minSdkVersion="14" android:targetSdkVersion="23" />
77
<uses-permission android:name="android.permission.WAKE_LOCK" />
88
<uses-permission android:name="com.google.android.c2dm.permission.RECEIVE" />
99

1010
<permission
11-
android:name="com.google.firebase.codelab.friendlychat.permission.C2D_MESSAGE"
11+
android:name="com.google.android.messaging.testapp.permission.C2D_MESSAGE"
1212
android:protectionLevel="signature" />
1313
<uses-permission
14-
android:name="com.google.firebase.codelab.friendlychat.permission.C2D_MESSAGE" />
14+
android:name="com.google.android.messaging.testapp.permission.C2D_MESSAGE" />
1515

1616
<application android:label="@string/app_name">
1717

@@ -29,7 +29,7 @@
2929
android:permission="com.google.android.c2dm.permission.SEND" >
3030
<intent-filter>
3131
<action android:name="com.google.android.c2dm.intent.RECEIVE" />
32-
<category android:name="com.google.firebase.codelab.friendlychat" />
32+
<category android:name="com.google.android.messaging.testapp" />
3333
</intent-filter>
3434
</receiver>
3535

messaging/testapp/src/common_main.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,9 @@ extern "C" int common_main(int argc, const char* argv[]) {
7272
::firebase::messaging::Subscribe("/topics/TestTopic");
7373
LogMessage("Subscribed to TestTopic");
7474

75-
#if defined(__ANDROID__)
7675
while (!ProcessEvents(1000)) {
7776
// Process events so that the client doesn't hang.
7877
LogMessage("Main tick");
7978
}
80-
#endif // defined(__ANDROID__)
8179
return 0;
8280
}

messaging/testapp/src/ios/ios_main.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ - (BOOL)application:(UIApplication *)application
5353
// Override point for customization after application launch.
5454
// TOOD(smiles): This needs to run on a separate thread so UIApplicationMain() can
5555
// notify our app delegate with events.
56-
dispatch_async(dispatch_get_main_queue(), ^{
56+
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
5757
const char *argv[] = {FIREBASE_TESTAPP_NAME};
5858
exit_status = common_main(1, argv);
5959
});

messaging/testapp/testapp/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<key>CFBundleExecutable</key>
88
<string>$(EXECUTABLE_NAME)</string>
99
<key>CFBundleIdentifier</key>
10-
<string>com.google.GCMSample.dev</string>
10+
<string>com.google.ios.messaging.testapp</string>
1111
<key>CFBundleInfoDictionaryVersion</key>
1212
<string>6.0</string>
1313
<key>CFBundleName</key>

0 commit comments

Comments
 (0)