Bump version to 3.0.5 and update dependencies; fix various issues in feature management and presentation (#9)

hrubalski · web-flow · commit c80f56e57bee · 2025-03-03T15:42:46.000+01:00
diff --git a/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme b/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
@@ -50,6 +50,7 @@
       ignoresPersistentStateOnLaunch = "NO"
       debugDocumentVersioning = "YES"
       debugServiceExtension = "internal"
+      enableGPUValidationMode = "1"
       allowLocationSimulation = "YES">
       <BuildableProductRunnable
          runnableDebuggingMode = "0">
diff --git a/example/pubspec.yaml b/example/pubspec.yaml
@@ -13,16 +13,16 @@ dependencies:
   flutter:
     sdk: flutter
 
-  feature_manager: ^3.0.4
+  feature_manager: ^3.0.5
 
   provider: ^6.1.2
-  shared_preferences: ^2.3.3
+  shared_preferences: ^2.3.5
 
 dev_dependencies:
   build_runner:
   flutter_test:
     sdk: flutter
-  feature_manager_generator: ^3.0.4
+  feature_manager_generator: ^3.0.5
 
 # The following section is specific to Flutter.
 flutter:
diff --git a/feature_manager/CHANGELOG.md b/feature_manager/CHANGELOG.md
@@ -1,3 +1,9 @@
+## 3.0.5
+
+- Fixed an issue where the Developer Preferences screen did not update after a value change.
+- Resolved an issue causing the `TextFeature` to appear under the `JsonFeature` flow.
+- Fixed a saving issue in the `JsonFeature`.
+
 ## 3.0.4
 
 ### Breaking Changes 🔥
diff --git a/feature_manager/lib/src/cubit/features_cubit.dart b/feature_manager/lib/src/cubit/features_cubit.dart
@@ -13,19 +13,17 @@ class FeaturesCubit extends Cubit<FeaturesState> {
   final FeatureRepository repository;
   StreamSubscription<List<Feature<dynamic>>>? _featuresSubscription;
 
-  Future<void> getFeatures() async {
+  void getFeatures() {
     try {
       emit(FeaturesLoading());
 
-      final features = await repository.getFeatures();
+      final features = repository.getFeatures();
 
       if (features.isNotEmpty) {
         emit(FeaturesSuccess(features));
       } else {
         emit(FeaturesEmpty());
       }
-
-      _listenFeatures();
     } catch (e) {
       if (kDebugMode) {
         print('FeatureManager error >> $e');
@@ -40,6 +38,7 @@ class FeaturesCubit extends Cubit<FeaturesState> {
   ) async {
     try {
       await repository.putValue(feature, value);
+      getFeatures();
     } catch (e) {
       if (kDebugMode) {
         print('FeatureManager error >> $e');
@@ -48,24 +47,6 @@ class FeaturesCubit extends Cubit<FeaturesState> {
     }
   }
 
-  void _listenFeatures() {
-    _featuresSubscription ??= repository.getFeaturesStream().distinct().listen(
-      (features) {
-        if (features.isNotEmpty) {
-          emit(FeaturesSuccess(features));
-        } else {
-          emit(FeaturesEmpty());
-        }
-      },
-      onError: (dynamic e) {
-        if (kDebugMode) {
-          print('FeatureManager error >> $e');
-        }
-        emit(FeaturesError());
-      },
-    );
-  }
-
   @override
   Future<void> close() {
     _featuresSubscription?.cancel();
diff --git a/feature_manager/lib/src/data/feature_repository.dart b/feature_manager/lib/src/data/feature_repository.dart
@@ -7,31 +7,22 @@ import 'package:shared_preferences/shared_preferences.dart';
 
 class FeatureRepository {
   FeatureRepository({
-    required this.featuresList,
+    required List<Feature<dynamic>> featuresList,
     required SharedPreferences sharedPreferences,
-  }) : _sharedPreferences = sharedPreferences {
-    _featuresStreamController = StreamController<List<Feature<dynamic>>>.broadcast();
-  }
+  })  : _featuresList = featuresList,
+        _sharedPreferences = sharedPreferences;
 
-  final List<Feature<dynamic>> featuresList;
+  final List<Feature<dynamic>> _featuresList;
   final SharedPreferences _sharedPreferences;
 
-  late StreamController<List<Feature<dynamic>>> _featuresStreamController;
-
-  Stream<List<Feature<dynamic>>> getFeaturesStream() => _featuresStreamController.stream;
-
-  Future<List<Feature<dynamic>>> getFeatures() async {
-    _featuresStreamController.add(featuresList);
-    return featuresList;
-  }
+  List<Feature<dynamic>> getFeatures() => _featuresList;
 
   Future<void> putValue(
     Feature<dynamic> feature,
     Object? value,
   ) async {
     if (value == null) {
       await _sharedPreferences.remove(feature.key);
-      await getFeatures();
       return;
     }
     if (feature.isText && value is String) {
@@ -47,6 +38,5 @@ class FeatureRepository {
     } else {
       throw Exception('Invalid value type');
     }
-    await getFeatures();
   }
 }
diff --git a/feature_manager/lib/src/presentation/feature_item.dart b/feature_manager/lib/src/presentation/feature_item.dart
@@ -145,7 +145,7 @@ class _FeatureItemState extends State<_FeatureItem> {
                 } else if (item.isInteger) {
                   widget.onChanged(text.isEmpty ? 0 : int.tryParse(text));
                 } else if (item.isJson) {
-                  widget.onChanged(text.isEmpty ? null : jsonEncode(text));
+                  widget.onChanged(text.isEmpty ? null : jsonDecode(text));
                 } else {
                   widget.onChanged(text);
                 }
diff --git a/feature_manager/lib/src/presentation/features_screen.dart b/feature_manager/lib/src/presentation/features_screen.dart
@@ -67,7 +67,7 @@ class _DeveloperPreferencesScreenState extends State<DeveloperPreferencesScreen>
           } else if (featuresState is FeaturesError) {
             return const _Error();
           }
-          return Container();
+          return const SizedBox.shrink();
         },
       ),
     );
@@ -87,9 +87,7 @@ class _Success extends StatelessWidget {
         final preference = preferences[index];
         return _FeatureItem(
           preference,
-          onChanged: (newValue) {
-            cubit.changeFeature(preference, newValue);
-          },
+          onChanged: (newValue) => cubit.changeFeature(preference, newValue),
         );
       },
       itemCount: preferences.length,
diff --git a/feature_manager/lib/src/utils/extensions.dart b/feature_manager/lib/src/utils/extensions.dart
@@ -37,5 +37,5 @@ extension FeatureBooleanExt<T> on Feature<T> {
   bool get isInteger => this is Feature<int>;
 
   /// Returns true if this Json Feature
-  bool get isJson => this is Feature<Object>;
+  bool get isJson => this is Feature<Map<String, dynamic>>;
 }
diff --git a/feature_manager/pubspec.yaml b/feature_manager/pubspec.yaml
@@ -3,7 +3,7 @@ description: Feature manager for developer preferences and experiments
 repository: https://github.com/theRealGetman/feature-manager/tree/master/feature_manager
 issue_tracker: https://github.com/theRealGetman/feature-manager/issues
 
-version: 3.0.4
+version: 3.0.5
 
 environment:
   sdk: ">=3.2.4 <4.0.0"
diff --git a/feature_manager/test/data/feature_repository_test.dart b/feature_manager/test/data/feature_repository_test.dart
@@ -122,7 +122,7 @@ void main() {
       );
 
       // when
-      final features = await target.getFeatures();
+      final features = target.getFeatures();
 
       // then
       expect(features[0].value, true);
diff --git a/generator/CHANGELOG.md b/generator/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 3.0.5
+
+- Update a dependency to the latest release
+
 ## 3.0.4
 
 ### Refactored Feature Type Handling:
diff --git a/generator/pubspec.yaml b/generator/pubspec.yaml
@@ -3,7 +3,7 @@ description: Feature manager generator for developer preferences and experiments
 repository: https://github.com/theRealGetman/feature-manager/tree/master/generator
 issue_tracker: https://github.com/theRealGetman/feature-manager/issues
 
-version: 3.0.4
+version: 3.0.5
 
 environment:
   sdk: ">=3.2.4 <4.0.0"
@@ -12,7 +12,7 @@ dependencies:
   analyzer: ^6.7.0
   build: ^2.4.1
   source_gen: ^1.5.0
-  feature_manager: ^3.0.4
+  feature_manager: ^3.0.5
 
 dev_dependencies:
   lints: ^5.1.1

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ class _FeatureItemState extends State<_FeatureItem> {`
`145`	`145`	`} else if (item.isInteger) {`
`146`	`146`	`widget.onChanged(text.isEmpty ? 0 : int.tryParse(text));`
`147`	`147`	`} else if (item.isJson) {`
`148`		`- widget.onChanged(text.isEmpty ? null : jsonEncode(text));`
	`148`	`+ widget.onChanged(text.isEmpty ? null : jsonDecode(text));`
`149`	`149`	`} else {`
`150`	`150`	`widget.onChanged(text);`
`151`	`151`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,5 +37,5 @@ extension FeatureBooleanExt<T> on Feature<T> {`
`37`	`37`	`bool get isInteger => this is Feature<int>;`
`38`	`38`
`39`	`39`	`/// Returns true if this Json Feature`
`40`		`- bool get isJson => this is Feature<Object>;`
	`40`	`+ bool get isJson => this is Feature<Map<String, dynamic>>;`
`41`	`41`	`}`