Keep only errors starting on new screen

sheetalkamat · sheetalkamat · commit 0831edab3648 · 2018-08-21T13:41:32.000-07:00
diff --git a/src/compiler/watch.ts b/src/compiler/watch.ts
@@ -27,12 +27,6 @@ namespace ts {
         };
     }
 
-    /** @internal */
-    export const nonClearingMessageCodes: number[] = [
-        Diagnostics.Found_1_error_Watching_for_file_changes.code,
-        Diagnostics.Found_0_errors_Watching_for_file_changes.code
-    ];
-
     /**
      * @returns Whether the screen was cleared.
      */
@@ -41,7 +35,7 @@ namespace ts {
             !options.preserveWatchOutput &&
             !options.extendedDiagnostics &&
             !options.diagnostics &&
-            !contains(nonClearingMessageCodes, diagnostic.code)) {
+            contains(screenStartingMessageCodes, diagnostic.code)) {
             system.clearScreen();
             return true;
         }
diff --git a/src/testRunner/unittests/tscWatchMode.ts b/src/testRunner/unittests/tscWatchMode.ts
@@ -110,7 +110,7 @@ namespace ts.tscWatch {
 
         function assertWatchDiagnostic(diagnostic: Diagnostic) {
             const expected = getWatchDiagnosticWithoutDate(diagnostic);
-            if (!disableConsoleClears && !contains(nonClearingMessageCodes, diagnostic.code)) {
+            if (!disableConsoleClears && contains(screenStartingMessageCodes, diagnostic.code)) {
                 assert.equal(host.screenClears[screenClears], index, `Expected screen clear at this diagnostic: ${expected}`);
                 screenClears++;
             }

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ namespace ts.tscWatch {`
`110`	`110`
`111`	`111`	`function assertWatchDiagnostic(diagnostic: Diagnostic) {`
`112`	`112`	`const expected = getWatchDiagnosticWithoutDate(diagnostic);`
`113`		`- if (!disableConsoleClears && !contains(nonClearingMessageCodes, diagnostic.code)) {`
	`113`	`+ if (!disableConsoleClears && contains(screenStartingMessageCodes, diagnostic.code)) {`
`114`	`114`	assert.equal(host.screenClears[screenClears], index, `Expected screen clear at this diagnostic: ${expected}`);
`115`	`115`	`screenClears++;`
`116`	`116`	`}`