Visit destructuring computed names (microsoft#18052)

weswigham · web-flow · commit 38c3f6765258 · 2017-08-25T15:10:47.000-07:00
diff --git a/src/compiler/transformers/destructuring.ts b/src/compiler/transformers/destructuring.ts
@@ -409,7 +409,7 @@ namespace ts {
      */
     function createDestructuringPropertyAccess(flattenContext: FlattenContext, value: Expression, propertyName: PropertyName): LeftHandSideExpression {
         if (isComputedPropertyName(propertyName)) {
-            const argumentExpression = ensureIdentifier(flattenContext, propertyName.expression, /*reuseIdentifierExpressions*/ false, /*location*/ propertyName);
+            const argumentExpression = ensureIdentifier(flattenContext, visitNode(propertyName.expression, flattenContext.visitor), /*reuseIdentifierExpressions*/ false, /*location*/ propertyName);
             return createElementAccess(value, argumentExpression);
         }
         else if (isStringOrNumericLiteral(propertyName)) {
diff --git a/tests/baselines/reference/computerPropertiesInES5ShouldBeTransformed.js b/tests/baselines/reference/computerPropertiesInES5ShouldBeTransformed.js
@@ -0,0 +1,8 @@
+//// [computerPropertiesInES5ShouldBeTransformed.ts]
+const b = ({ [`key`]: renamed }) => renamed;
+
+//// [computerPropertiesInES5ShouldBeTransformed.js]
+var b = function (_a) {
+    var _b = "key", renamed = _a[_b];
+    return renamed;
+};
diff --git a/tests/baselines/reference/computerPropertiesInES5ShouldBeTransformed.symbols b/tests/baselines/reference/computerPropertiesInES5ShouldBeTransformed.symbols
@@ -0,0 +1,6 @@
+=== tests/cases/compiler/computerPropertiesInES5ShouldBeTransformed.ts ===
+const b = ({ [`key`]: renamed }) => renamed;
+>b : Symbol(b, Decl(computerPropertiesInES5ShouldBeTransformed.ts, 0, 5))
+>renamed : Symbol(renamed, Decl(computerPropertiesInES5ShouldBeTransformed.ts, 0, 12))
+>renamed : Symbol(renamed, Decl(computerPropertiesInES5ShouldBeTransformed.ts, 0, 12))
+
diff --git a/tests/baselines/reference/computerPropertiesInES5ShouldBeTransformed.types b/tests/baselines/reference/computerPropertiesInES5ShouldBeTransformed.types
@@ -0,0 +1,8 @@
+=== tests/cases/compiler/computerPropertiesInES5ShouldBeTransformed.ts ===
+const b = ({ [`key`]: renamed }) => renamed;
+>b : ({ [`key`]: renamed }: {}) => any
+>({ [`key`]: renamed }) => renamed : ({ [`key`]: renamed }: {}) => any
+>`key` : "key"
+>renamed : any
+>renamed : any
+
diff --git a/tests/cases/compiler/computerPropertiesInES5ShouldBeTransformed.ts b/tests/cases/compiler/computerPropertiesInES5ShouldBeTransformed.ts
@@ -0,0 +1,2 @@
+// @target: es5
+const b = ({ [`key`]: renamed }) => renamed;

Original file line number	Diff line number	Diff line change
`@@ -409,7 +409,7 @@ namespace ts {`
`409`	`409`	`*/`
`410`	`410`	`function createDestructuringPropertyAccess(flattenContext: FlattenContext, value: Expression, propertyName: PropertyName): LeftHandSideExpression {`
`411`	`411`	`if (isComputedPropertyName(propertyName)) {`
`412`		`- const argumentExpression = ensureIdentifier(flattenContext, propertyName.expression, /reuseIdentifierExpressions/ false, /location/ propertyName);`
	`412`	`+ const argumentExpression = ensureIdentifier(flattenContext, visitNode(propertyName.expression, flattenContext.visitor), /reuseIdentifierExpressions/ false, /location/ propertyName);`
`413`	`413`	`return createElementAccess(value, argumentExpression);`
`414`	`414`	`}`
`415`	`415`	`else if (isStringOrNumericLiteral(propertyName)) {`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+// @target: es5`
	`2`	+const b = ({ [`key`]: renamed }) => renamed;