Skip to content

Repo: migrate eslint-plugin-react to @eslint-react/eslint-plugin #11214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JounQin opened this issue May 14, 2025 · 4 comments
Open

Repo: migrate eslint-plugin-react to @eslint-react/eslint-plugin #11214

JounQin opened this issue May 14, 2025 · 4 comments
Labels
awaiting response Issues waiting for a reply from the OP or another party repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JounQin
Copy link
Contributor

JounQin commented May 14, 2025

Suggestion

https://github.com/Rel1cx/eslint-react is much modern and performant by design.

Additional Info

No response

@JounQin JounQin added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels May 14, 2025
@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented May 14, 2025

is much modern and performant by design

I believe you, but can you back this up please? 🙂

As in: I'm totally on board with e18e initiatives, just we need details before jumping onto something new.

  • Modern: what are the API differences? Why are they better?
  • Performance: got stats? what's different?

@JoshuaKGoldberg JoshuaKGoldberg added awaiting response Issues waiting for a reply from the OP or another party and removed triage Waiting for team members to take a look labels May 14, 2025
@JounQin
Copy link
Contributor Author

JounQin commented May 14, 2025

I believe @Rel1cx may have better answer.

@JounQin
Copy link
Contributor Author

JounQin commented May 18, 2025

@JoshuaKGoldberg

Just found https://eslint-react.xyz/docs/faq

Does this make sense for you?

@JoshuaKGoldberg
Copy link
Member

It makes sense but doesn't answer my questions 🙂. This is a point of feedback that I've had on a lot of e18e-style initiatives: we need real evidence. That FAQ is a good FAQ for high-level ideas of the plugin. But I want actual answers to:

  • Modern: what are the API differences? Why are they better?
  • Performance: got stats? what's different?

The performance point in particular is not answered there. When someone says something has better performance, that needs to be backed up with actual measurements / numbers. People make incorrect performance claims all the time. Oftentimes it's because they measure in some types of projects but not others.

FWIW I like the new eslint-react project and think it has a lot of good stuff in it. But we need to do due diligence before jumping to something new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response Issues waiting for a reply from the OP or another party repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

No branches or pull requests

2 participants