Skip to content

Repo(typescript-estree): Build out test cases using using fixtures for project service tests to reduce mocking #9641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
higherorderfunctor opened this issue Jul 25, 2024 · 1 comment
Open

Repo(typescript-estree): Build out test cases using using fixtures for project service tests to reduce mocking #9641

higherorderfunctor opened this issue Jul 25, 2024 · 1 comment
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs team assigned A member of the typescript-eslint team should work on this. tests anything to do with testing

Comments

@higherorderfunctor
Copy link
Contributor

Suggestion

Follow up from #9306.

we should probably build out a test case using typescript-estree/tests/fixtures that allows us to do tests with project service without mocking out the entire world.

Project service test cases require quite a bit of mocking in createProjectService.test.ts. Suggestion is to build out test cases using fixtures to reduce the number of tsserver mocks.
@higherorderfunctor higherorderfunctor added repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for team members to take a look labels Jul 25, 2024
@higherorderfunctor higherorderfunctor mentioned this issue Jul 25, 2024
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg added tests anything to do with testing accepting prs Go ahead, send a pull request that resolves this issue team assigned A member of the typescript-eslint team should work on this. and removed triage Waiting for team members to take a look accepting prs Go ahead, send a pull request that resolves this issue labels Aug 22, 2024
@JoshuaKGoldberg
Copy link
Member

Thanks for filing!

The integration tests can get pretty hairy, so I'm marking this as team assigned for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs team assigned A member of the typescript-eslint team should work on this. tests anything to do with testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoshuaKGoldberg @higherorderfunctor