-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
⚡️ Performance: Default parserOptions.jsDocParsingMode to 'none' or 'type-info' #9857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello, coming over from an X thread. I maintain another third-party plugin that relies on parsed JSDoc information, though not very popular. 😅 https://github.com/uhyo/eslint-plugin-import-access The plugin sees JSDoc tags I'm not severly requesting to keep the slower I just wanted to share my use case of JSDoc parsing and also my humble hope that the planned alternative JSDoc parser (#9858) could be extended so that it can be used for third-party use cases too. Thank you 🙂 |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@silverwind please don't hop on unrelated threads to ask questions! But Josh is right -- the first rule bears the brunt of the type info that gets lazily computed and cached. If you isolated the test runs you'd see they should be equivalent perf. |
This issue is motivated by the new rule, because we are now in the business of checking JSDoc. :) |
@Josh-Cena thanks for clarification, I will run my benchmark on these rules in isolation so that each rule has to bear the jsDoc loading cost. I expect the two rules to perform similarily under those conditions. |
If you find it's slower - please file a new issue! |
Uh oh!
There was an error while loading. Please reload this page.
Overview
Following conversations in #7997 and #9783 (comment): we'd previously added a
parserOptions.jsDocParsingMode
that API consumers can use to skip parsing JSDoc comments. JSDoc comment parsing can be quite expensive.We'd previously been blocked from doing so because at least one popular ecosystem project,
eslint-plugin-deprecation
, uses them. Our initial version of adeprecation
rule does too: #9783. So this issue is blocked until we create a suitable alternative, such as our own quick regexp parser.See also #7906 for tracking running a performance comparison.
💖
The text was updated successfully, but these errors were encountered: