From 273071cd991ef8aa4a1a3a0108409b5672c75fad Mon Sep 17 00:00:00 2001
From: James Garbutt <43081j@users.noreply.github.com>
Date: Tue, 31 Dec 2024 17:30:50 +0000
Subject: [PATCH 1/6] chore: add test-coverage script

Adds a `test-coverage` script to each package.

With this change, each package has these two scripts:

- `test` - run tests with coverage disabled
- `test-coverage` - run tests with coverage enabled (_if_ the package
  wants to support coverage)

Before this change, `test` behaved like `test-coverage` (i.e. packages
had coverage enabled in it). In CI, we then forced coverage off in some
situations by passing a flag: `npm run test -- --coverage=false`.

This resulted in commands like `jest --coverage --coverage=false`.

While jest is happy with this, vitest is not. Given we are likely to
move to vitest, it is worth fixing this ahead of time.
---
 .github/workflows/ci.yml                              | 9 ++++-----
 packages/ast-spec/package.json                        | 1 +
 packages/eslint-plugin-internal/package.json          | 3 ++-
 packages/eslint-plugin/package.json                   | 3 ++-
 packages/parser/package.json                          | 3 ++-
 packages/rule-schema-to-typescript-types/package.json | 3 ++-
 packages/rule-tester/package.json                     | 3 ++-
 packages/scope-manager/package.json                   | 3 ++-
 packages/type-utils/package.json                      | 3 ++-
 packages/typescript-eslint/package.json               | 3 ++-
 packages/typescript-estree/package.json               | 3 ++-
 packages/utils/package.json                           | 3 ++-
 packages/visitor-keys/package.json                    | 3 ++-
 13 files changed, 27 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 356d319a5a9a..d555f41f5db7 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -197,17 +197,16 @@ jobs:
 
       # collect coverage on the primary node version
       # we don't collect coverage on other node versions so they run faster
-      # note that we don't do this as a single `run` with a flag because some
-      # packages don't collect coverage on purpose, so forcing `--coverage=true`
-      # would override the config
+      # note that not all packages will collect coverage in their
+      # test-coverage script on purpose
       - name: Run unit tests with coverage for ${{ matrix.package }}
         if: env.PRIMARY_NODE_VERSION == matrix.node-version && matrix.os == 'ubuntu-latest'
-        run: npx nx test ${{ matrix.package }}
+        run: npx nx run ${{ matrix.package }}:test-coverage
         env:
           CI: true
       - name: Run unit tests for ${{ matrix.package }}
         if: env.PRIMARY_NODE_VERSION != matrix.node-version || matrix.os != 'ubuntu-latest'
-        run: npx nx test ${{ matrix.package }} --coverage=false
+        run: npx nx test ${{ matrix.package }}
         env:
           CI: true
 
diff --git a/packages/ast-spec/package.json b/packages/ast-spec/package.json
index 30af8caa6b5d..3504f15fbf5c 100644
--- a/packages/ast-spec/package.json
+++ b/packages/ast-spec/package.json
@@ -37,6 +37,7 @@
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
     "test": "jest",
+    "test-coverage": "jest",
     "typecheck": "tsc --noEmit"
   },
   "funding": {
diff --git a/packages/eslint-plugin-internal/package.json b/packages/eslint-plugin-internal/package.json
index 3ce2ccfa0ab1..5853af40e094 100644
--- a/packages/eslint-plugin-internal/package.json
+++ b/packages/eslint-plugin-internal/package.json
@@ -19,7 +19,8 @@
     "postclean": "rimraf dist && rimraf coverage",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
-    "test": "jest --coverage",
+    "test": "jest",
+    "test-coverage": "jest --coverage",
     "typecheck": "npx tsc --noEmit"
   },
   "dependencies": {
diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
index ab47506850f2..99096dffc345 100644
--- a/packages/eslint-plugin/package.json
+++ b/packages/eslint-plugin/package.json
@@ -55,7 +55,8 @@
     "generate:breaking-changes": "tsx tools/generate-breaking-changes.mts",
     "generate:configs": "npx nx generate-configs repo",
     "lint": "npx nx lint",
-    "test": "cross-env NODE_OPTIONS=\"--experimental-vm-modules\" jest --coverage --logHeapUsage",
+    "test": "cross-env NODE_OPTIONS=\"--experimental-vm-modules\" jest --logHeapUsage",
+    "test-coverage": "cross-env NODE_OPTIONS=\"--experimental-vm-modules\" jest --coverage --logHeapUsage",
     "test-single": "cross-env NODE_OPTIONS=\"--experimental-vm-modules\" jest --no-coverage",
     "typecheck": "tsc --noEmit"
   },
diff --git a/packages/parser/package.json b/packages/parser/package.json
index b5be2259dd1f..ffb505ed8f63 100644
--- a/packages/parser/package.json
+++ b/packages/parser/package.json
@@ -45,7 +45,8 @@
     "postclean": "rimraf dist && rimraf _ts4.3 && rimraf coverage",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
-    "test": "jest --coverage",
+    "test": "jest",
+    "test-coverage": "jest --coverage",
     "typecheck": "tsc --noEmit"
   },
   "peerDependencies": {
diff --git a/packages/rule-schema-to-typescript-types/package.json b/packages/rule-schema-to-typescript-types/package.json
index 6847da23df10..b5908dc37fe6 100644
--- a/packages/rule-schema-to-typescript-types/package.json
+++ b/packages/rule-schema-to-typescript-types/package.json
@@ -30,7 +30,8 @@
     "generate-sponsors": "tsx ./src/generate-sponsors.ts",
     "lint": "npx nx lint",
     "postinstall-script": "tsx ./src/postinstall.ts",
-    "test": "npx jest --coverage",
+    "test": "npx jest",
+    "test-coverage": "npx jest --coverage",
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
diff --git a/packages/rule-tester/package.json b/packages/rule-tester/package.json
index 72fc6f8c972a..2d6b05471aff 100644
--- a/packages/rule-tester/package.json
+++ b/packages/rule-tester/package.json
@@ -43,7 +43,8 @@
     "lint": "npx nx lint",
     "pretest-eslint-base": "tsc -b tsconfig.build.json",
     "test-eslint-base": "mocha --require source-map-support/register ./tests/eslint-base/eslint-base.test.js",
-    "test": "npx jest --coverage",
+    "test": "npx jest",
+    "test-coverage": "npx jest --coverage",
     "typecheck": "tsc --noEmit"
   },
   "//": "NOTE - AJV is out-of-date, but it's intentionally synced with ESLint - https://github.com/eslint/eslint/blob/ad9dd6a933fd098a0d99c6a9aa059850535c23ee/package.json#L70",
diff --git a/packages/scope-manager/package.json b/packages/scope-manager/package.json
index 76652585660c..ddc3367ce7be 100644
--- a/packages/scope-manager/package.json
+++ b/packages/scope-manager/package.json
@@ -42,7 +42,8 @@
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "generate-lib": "npx nx generate-lib repo",
     "lint": "npx nx lint",
-    "test": "npx nx test --code-coverage",
+    "test": "npx nx test",
+    "test-coverage": "npx nx test --code-coverage",
     "typecheck": "npx nx typecheck"
   },
   "dependencies": {
diff --git a/packages/type-utils/package.json b/packages/type-utils/package.json
index 667910689ccb..527fad45cf06 100644
--- a/packages/type-utils/package.json
+++ b/packages/type-utils/package.json
@@ -42,7 +42,8 @@
     "postclean": "rimraf dist && rimraf _ts3.4 && rimraf _ts4.3 && rimraf coverage",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
-    "test": "jest --coverage",
+    "test": "jest",
+    "test-coverage": "jest --coverage",
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
diff --git a/packages/typescript-eslint/package.json b/packages/typescript-eslint/package.json
index 21558c3d6327..17640dfc4b16 100644
--- a/packages/typescript-eslint/package.json
+++ b/packages/typescript-eslint/package.json
@@ -48,7 +48,8 @@
     "postclean": "rimraf dist && rimraf _ts4.3 && rimraf coverage",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "nx lint",
-    "test": "jest --coverage --passWithNoTests",
+    "test": "jest --passWithNoTests",
+    "test-coverage": "jest --coverage --passWithNoTests",
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
diff --git a/packages/typescript-estree/package.json b/packages/typescript-estree/package.json
index a9b75afc0474..fabf5da1c19c 100644
--- a/packages/typescript-estree/package.json
+++ b/packages/typescript-estree/package.json
@@ -50,7 +50,8 @@
     "postclean": "rimraf dist && rimraf _ts4.3 && rimraf coverage",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
-    "test": "jest --coverage --runInBand --verbose",
+    "test": "jest --runInBand --verbose",
+    "test-coverage": "jest --coverage --runInBand --verbose",
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
diff --git a/packages/utils/package.json b/packages/utils/package.json
index 603265f73c00..d4762e170bd7 100644
--- a/packages/utils/package.json
+++ b/packages/utils/package.json
@@ -59,7 +59,8 @@
     "postclean": "rimraf dist && rimraf _ts3.4 && rimraf _ts4.3 && rimraf coverage",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
-    "test": "jest --coverage",
+    "test": "jest",
+    "test-coverage": "jest --coverage",
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
diff --git a/packages/visitor-keys/package.json b/packages/visitor-keys/package.json
index 7d7edd0ccf61..53eea0557e71 100644
--- a/packages/visitor-keys/package.json
+++ b/packages/visitor-keys/package.json
@@ -43,7 +43,8 @@
     "postclean": "rimraf dist && rimraf _ts3.4 && rimraf _ts4.3 && rimraf coverage",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
-    "test": "jest --coverage",
+    "test": "jest",
+    "test-coverage": "jest --coverage",
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {

From 9432df5b20931c5be3b7cb7dfa951548ea82bfb5 Mon Sep 17 00:00:00 2001
From: James Garbutt <43081j@users.noreply.github.com>
Date: Tue, 28 Jan 2025 23:40:41 +0000
Subject: [PATCH 2/6] chore(ast-spec): enable test coverage

---
 .github/workflows/ci.yml         | 2 --
 packages/ast-spec/jest.config.js | 1 +
 packages/ast-spec/package.json   | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index d555f41f5db7..6c1008f7d5fb 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -197,8 +197,6 @@ jobs:
 
       # collect coverage on the primary node version
       # we don't collect coverage on other node versions so they run faster
-      # note that not all packages will collect coverage in their
-      # test-coverage script on purpose
       - name: Run unit tests with coverage for ${{ matrix.package }}
         if: env.PRIMARY_NODE_VERSION == matrix.node-version && matrix.os == 'ubuntu-latest'
         run: npx nx run ${{ matrix.package }}:test-coverage
diff --git a/packages/ast-spec/jest.config.js b/packages/ast-spec/jest.config.js
index 6b927c0166bd..060e8c19403e 100644
--- a/packages/ast-spec/jest.config.js
+++ b/packages/ast-spec/jest.config.js
@@ -12,4 +12,5 @@ module.exports = {
     ...baseConfig.setupFilesAfterEnv,
     './tests/util/setupJest.ts',
   ],
+  coveragePathIgnorePatterns: ['/fixtures/', '/node_modules/'],
 };
diff --git a/packages/ast-spec/package.json b/packages/ast-spec/package.json
index c87e896d5ed2..60139f7dc981 100644
--- a/packages/ast-spec/package.json
+++ b/packages/ast-spec/package.json
@@ -37,7 +37,7 @@
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
     "test": "jest",
-    "test-coverage": "jest",
+    "test-coverage": "jest --coverage",
     "typecheck": "tsc --noEmit"
   },
   "funding": {

From 800ab66b9c995fa6145062c0a028ab55d1ae3378 Mon Sep 17 00:00:00 2001
From: James Garbutt <43081j@users.noreply.github.com>
Date: Thu, 30 Jan 2025 22:16:16 +0000
Subject: [PATCH 3/6] chore(scope-manager): add jest as dependency

---
 packages/scope-manager/package.json | 5 +++--
 yarn.lock                           | 1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/packages/scope-manager/package.json b/packages/scope-manager/package.json
index 7c3625505d8e..3080f4006d63 100644
--- a/packages/scope-manager/package.json
+++ b/packages/scope-manager/package.json
@@ -42,8 +42,8 @@
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "generate-lib": "npx nx generate-lib repo",
     "lint": "npx nx lint",
-    "test": "npx nx test",
-    "test-coverage": "npx nx test --code-coverage",
+    "test": "jest",
+    "test-coverage": "jest --coverage",
     "typecheck": "npx nx typecheck"
   },
   "dependencies": {
@@ -55,6 +55,7 @@
     "@types/glob": "*",
     "@typescript-eslint/typescript-estree": "8.22.0",
     "glob": "*",
+    "jest": "29.7.0",
     "jest-specific-snapshot": "*",
     "make-dir": "*",
     "prettier": "^3.2.5",
diff --git a/yarn.lock b/yarn.lock
index 07b98231ab9a..cdc09af9973e 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -5859,6 +5859,7 @@ __metadata:
     "@typescript-eslint/typescript-estree": 8.22.0
     "@typescript-eslint/visitor-keys": 8.22.0
     glob: "*"
+    jest: 29.7.0
     jest-specific-snapshot: "*"
     make-dir: "*"
     prettier: ^3.2.5

From 2824c647982e552f046ce2755133e6d3c373293e Mon Sep 17 00:00:00 2001
From: James Garbutt <43081j@users.noreply.github.com>
Date: Fri, 31 Jan 2025 16:00:05 +0000
Subject: [PATCH 4/6] chore: drop coverage script

---
 .github/workflows/ci.yml                              | 2 +-
 packages/ast-spec/package.json                        | 1 -
 packages/eslint-plugin-internal/package.json          | 1 -
 packages/eslint-plugin/package.json                   | 1 -
 packages/parser/package.json                          | 1 -
 packages/rule-schema-to-typescript-types/package.json | 1 -
 packages/rule-tester/package.json                     | 1 -
 packages/scope-manager/package.json                   | 1 -
 packages/type-utils/package.json                      | 1 -
 packages/typescript-eslint/package.json               | 1 -
 packages/typescript-estree/package.json               | 1 -
 packages/utils/package.json                           | 1 -
 packages/visitor-keys/package.json                    | 1 -
 13 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 6c1008f7d5fb..e3d230aab6ed 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -199,7 +199,7 @@ jobs:
       # we don't collect coverage on other node versions so they run faster
       - name: Run unit tests with coverage for ${{ matrix.package }}
         if: env.PRIMARY_NODE_VERSION == matrix.node-version && matrix.os == 'ubuntu-latest'
-        run: npx nx run ${{ matrix.package }}:test-coverage
+        run: npx nx run ${{ matrix.package }}:test -- --coverage
         env:
           CI: true
       - name: Run unit tests for ${{ matrix.package }}
diff --git a/packages/ast-spec/package.json b/packages/ast-spec/package.json
index 60139f7dc981..b3d56ee2f4d1 100644
--- a/packages/ast-spec/package.json
+++ b/packages/ast-spec/package.json
@@ -37,7 +37,6 @@
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
     "test": "jest",
-    "test-coverage": "jest --coverage",
     "typecheck": "tsc --noEmit"
   },
   "funding": {
diff --git a/packages/eslint-plugin-internal/package.json b/packages/eslint-plugin-internal/package.json
index 5853af40e094..620651237c92 100644
--- a/packages/eslint-plugin-internal/package.json
+++ b/packages/eslint-plugin-internal/package.json
@@ -20,7 +20,6 @@
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
     "test": "jest",
-    "test-coverage": "jest --coverage",
     "typecheck": "npx tsc --noEmit"
   },
   "dependencies": {
diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
index 615e260da9f7..86c067280aef 100644
--- a/packages/eslint-plugin/package.json
+++ b/packages/eslint-plugin/package.json
@@ -56,7 +56,6 @@
     "generate:configs": "npx nx generate-configs repo",
     "lint": "npx nx lint",
     "test": "cross-env NODE_OPTIONS=\"--experimental-vm-modules\" jest --logHeapUsage",
-    "test-coverage": "cross-env NODE_OPTIONS=\"--experimental-vm-modules\" jest --coverage --logHeapUsage",
     "test-single": "cross-env NODE_OPTIONS=\"--experimental-vm-modules\" jest --no-coverage",
     "typecheck": "tsc --noEmit"
   },
diff --git a/packages/parser/package.json b/packages/parser/package.json
index 33e262471a2b..5cf7f4af3eae 100644
--- a/packages/parser/package.json
+++ b/packages/parser/package.json
@@ -46,7 +46,6 @@
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
     "test": "jest",
-    "test-coverage": "jest --coverage",
     "typecheck": "tsc --noEmit"
   },
   "peerDependencies": {
diff --git a/packages/rule-schema-to-typescript-types/package.json b/packages/rule-schema-to-typescript-types/package.json
index aa58578973fa..d17a49eb22db 100644
--- a/packages/rule-schema-to-typescript-types/package.json
+++ b/packages/rule-schema-to-typescript-types/package.json
@@ -31,7 +31,6 @@
     "lint": "npx nx lint",
     "postinstall-script": "tsx ./src/postinstall.ts",
     "test": "npx jest",
-    "test-coverage": "npx jest --coverage",
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
diff --git a/packages/rule-tester/package.json b/packages/rule-tester/package.json
index 68759dd273d9..8a808a318966 100644
--- a/packages/rule-tester/package.json
+++ b/packages/rule-tester/package.json
@@ -44,7 +44,6 @@
     "pretest-eslint-base": "tsc -b tsconfig.build.json",
     "test-eslint-base": "mocha --require source-map-support/register ./tests/eslint-base/eslint-base.test.js",
     "test": "npx jest",
-    "test-coverage": "npx jest --coverage",
     "typecheck": "tsc --noEmit"
   },
   "//": "NOTE - AJV is out-of-date, but it's intentionally synced with ESLint - https://github.com/eslint/eslint/blob/ad9dd6a933fd098a0d99c6a9aa059850535c23ee/package.json#L70",
diff --git a/packages/scope-manager/package.json b/packages/scope-manager/package.json
index 3080f4006d63..77d9b841c733 100644
--- a/packages/scope-manager/package.json
+++ b/packages/scope-manager/package.json
@@ -43,7 +43,6 @@
     "generate-lib": "npx nx generate-lib repo",
     "lint": "npx nx lint",
     "test": "jest",
-    "test-coverage": "jest --coverage",
     "typecheck": "npx nx typecheck"
   },
   "dependencies": {
diff --git a/packages/type-utils/package.json b/packages/type-utils/package.json
index ee7a05e3b780..d5a8686129f1 100644
--- a/packages/type-utils/package.json
+++ b/packages/type-utils/package.json
@@ -43,7 +43,6 @@
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
     "test": "jest",
-    "test-coverage": "jest --coverage",
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
diff --git a/packages/typescript-eslint/package.json b/packages/typescript-eslint/package.json
index 822a76a11e8c..92326e91beb3 100644
--- a/packages/typescript-eslint/package.json
+++ b/packages/typescript-eslint/package.json
@@ -49,7 +49,6 @@
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "nx lint",
     "test": "jest --passWithNoTests",
-    "test-coverage": "jest --coverage --passWithNoTests",
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
diff --git a/packages/typescript-estree/package.json b/packages/typescript-estree/package.json
index 514839f2b971..3816d4a92307 100644
--- a/packages/typescript-estree/package.json
+++ b/packages/typescript-estree/package.json
@@ -51,7 +51,6 @@
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
     "test": "jest --runInBand --verbose",
-    "test-coverage": "jest --coverage --runInBand --verbose",
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
diff --git a/packages/utils/package.json b/packages/utils/package.json
index 9e613719d505..5a5bfb9c9934 100644
--- a/packages/utils/package.json
+++ b/packages/utils/package.json
@@ -60,7 +60,6 @@
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
     "test": "jest",
-    "test-coverage": "jest --coverage",
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
diff --git a/packages/visitor-keys/package.json b/packages/visitor-keys/package.json
index 75a0a5144ff4..134f23987b8b 100644
--- a/packages/visitor-keys/package.json
+++ b/packages/visitor-keys/package.json
@@ -44,7 +44,6 @@
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
     "test": "jest",
-    "test-coverage": "jest --coverage",
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {

From 8160bacd43b023425ce4c4fa45005da789381a12 Mon Sep 17 00:00:00 2001
From: James Garbutt <43081j@users.noreply.github.com>
Date: Tue, 25 Feb 2025 13:38:02 +0000
Subject: [PATCH 5/6] chore: disable coverage in jest base config

---
 jest.config.base.js                       | 1 -
 packages/integration-tests/jest.config.js | 1 -
 2 files changed, 2 deletions(-)

diff --git a/jest.config.base.js b/jest.config.base.js
index fe816c4ca66e..a28164938fc9 100644
--- a/jest.config.base.js
+++ b/jest.config.base.js
@@ -6,7 +6,6 @@ const path = require('node:path');
 // @ts-check
 /** @type {import('@jest/types').Config.InitialOptions} */
 module.exports = {
-  collectCoverage: true,
   collectCoverageFrom: ['src/**/*.{js,jsx,ts,tsx}'],
   coverageReporters: ['lcov'],
   moduleFileExtensions: [
diff --git a/packages/integration-tests/jest.config.js b/packages/integration-tests/jest.config.js
index 2c4a6eacd5e4..81c7288cdf99 100644
--- a/packages/integration-tests/jest.config.js
+++ b/packages/integration-tests/jest.config.js
@@ -8,7 +8,6 @@ const { tseslintPackages } = require('./tools/pack-packages');
 /** @type {import('@jest/types').Config.InitialOptions} */
 module.exports = {
   ...require('../../jest.config.base.js'),
-  collectCoverage: false,
   globals: {
     tseslintPackages,
   },

From 479af6d401b4a5e780489807907b708a4680e5c6 Mon Sep 17 00:00:00 2001
From: Kirk Waiblinger <53019676+kirkwaiblinger@users.noreply.github.com>
Date: Wed, 26 Feb 2025 23:40:24 -0700
Subject: [PATCH 6/6] review changes

---
 packages/ast-spec/jest.config.js                      | 1 -
 packages/rule-schema-to-typescript-types/package.json | 1 -
 2 files changed, 2 deletions(-)

diff --git a/packages/ast-spec/jest.config.js b/packages/ast-spec/jest.config.js
index 060e8c19403e..3b80d72f30ae 100644
--- a/packages/ast-spec/jest.config.js
+++ b/packages/ast-spec/jest.config.js
@@ -7,7 +7,6 @@ const baseConfig = require('../../jest.config.base.js');
 /** @type {import('@jest/types').Config.InitialOptions} */
 module.exports = {
   ...baseConfig,
-  collectCoverage: false,
   setupFilesAfterEnv: [
     ...baseConfig.setupFilesAfterEnv,
     './tests/util/setupJest.ts',
diff --git a/packages/rule-schema-to-typescript-types/package.json b/packages/rule-schema-to-typescript-types/package.json
index 5fd8f7823141..cbfed2a08dd5 100644
--- a/packages/rule-schema-to-typescript-types/package.json
+++ b/packages/rule-schema-to-typescript-types/package.json
@@ -30,7 +30,6 @@
     "generate-sponsors": "tsx ./src/generate-sponsors.ts",
     "lint": "npx nx lint",
     "postinstall-script": "tsx ./src/postinstall.ts",
-    "test": "npx jest",
     "check-types": "npx nx typecheck"
   },
   "dependencies": {