Merge pull request microsoft#4744 from Microsoft/ben/fix-4739

joaomoreno · joaomoreno · commit 43ff6af3d456 · 2016-03-29T15:54:41.000+02:00
New untitiled file not saved on exit (fixes microsoft#4739)
diff --git a/src/vs/workbench/electron-browser/window.ts b/src/vs/workbench/electron-browser/window.ts
@@ -162,7 +162,11 @@ export class ElectronWindow {
 	}
 
 	public showSaveDialog(options: Electron.Dialog.SaveDialogOptions, callback?: (fileName: string) => void): string {
-		return dialog.showSaveDialog(this.win, options, callback);
+		if (callback) {
+			return dialog.showSaveDialog(this.win, options, callback);
+		}
+
+		return dialog.showSaveDialog(this.win, options);
 	}
 
 	public setFullScreen(fullscreen: boolean): void {

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,11 @@ export class ElectronWindow {`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`public showSaveDialog(options: Electron.Dialog.SaveDialogOptions, callback?: (fileName: string) => void): string {`
`165`		`- return dialog.showSaveDialog(this.win, options, callback);`
	`165`	`+ if (callback) {`
	`166`	`+ return dialog.showSaveDialog(this.win, options, callback);`
	`167`	`+ }`
	`168`	`+`
	`169`	`+ return dialog.showSaveDialog(this.win, options);`
`166`	`170`	`}`
`167`	`171`
`168`	`172`	`public setFullScreen(fullscreen: boolean): void {`