Node JS 24 with ICU 77 (#453)

sven-oly · web-flow · commit 47427d4559c2 · 2025-05-09T11:02:47.000-07:00
* Node JS 24 with ICU 77

* Removing old code that was giving warnings
diff --git a/run_config.json b/run_config.json
@@ -156,6 +156,28 @@
       "per_execution": 10000
     }
   },
+  {
+    "prereq": {
+      "name": "nvm 24.0.0, icu77.1",
+      "version": "24.0.0",
+      "command": "nvm install 24.0.0;nvm use 24.0.0 --silent"
+    },
+    "run": {
+      "icu_version": "icu77",
+      "exec": "node",
+      "test_type": [
+        "collation",
+        "datetime_fmt",
+        "list_fmt",
+        "number_fmt",
+        "lang_names",
+        "likely_subtags",
+        "rdt_fmt",
+        "plural_rules"
+      ],
+      "per_execution": 10000
+    }
+  },
   {
     "prereq": {
       "name": "nvm 23.3.0, icu76.1",
diff --git a/testdriver/datasets.py b/testdriver/datasets.py
@@ -221,6 +221,7 @@ class ParallelMode(Enum):
   ParallelByLang = 2
 
 class NodeVersion(Enum):
+  Node24 = "24.0.0"
   Node23 = "23.3.0"
   Node22 = "22.9.0"
   Node21 = "21.6.0"
@@ -252,8 +253,8 @@ class ICU4XVersion(Enum):
 # TODO: combine the version info
 IcuVersionToExecutorMap = {
     'node': {
-        '77': ["23.10.0"],  # NOT YET AVAILABLE
-        '76': ["23.3.0"],
+        '77': ["24.0.0"],
+        '76': ["23.11.0"],
         '75': ["22.9.0"],
         '74': ["21.6.0"],
         '73': ["20.1.0"],
@@ -278,8 +279,8 @@ class ICU4XVersion(Enum):
 # What versions of NodeJS use specific ICU versions
 # https://nodejs.org/en/download/releases/
 NodeICUVersionMap = {
-    '23.10.0': '77.1',  # NOT YET!!
-    '23.3.0': '76.1',
+    '24.0.0': '77.1',
+    '23.11.0': '76.1',
     '22.9.0': '75.1',
     '21.6.0': '74.1',
     '20.1.0': '73.1',
@@ -358,6 +359,10 @@ def has(self, exec):
 allExecutors = ExecutorInfo()
 
 system = ExecutorLang.NODE.value
+allExecutors.addSystem(system, NodeVersion.Node24,
+                       'node ../executors/node/executor.js',
+                       CLDRVersion.CLDR47, versionICU=ICUVersion.ICU77)
+
 allExecutors.addSystem(system, NodeVersion.Node21,
                        'node ../executors/node/executor.js',
                        CLDRVersion.CLDR43, versionICU=ICUVersion.ICU73)
diff --git a/testgen/generators/datetime_fmt.py b/testgen/generators/datetime_fmt.py
@@ -9,7 +9,6 @@
 import subprocess
 from generators.base import DataGenerator
 
-reblankline = re.compile("^\s*$")
 
 class DateTimeFmtGenerator(DataGenerator):
     json_test = {"test_type": "datetime_fmt"}
@@ -140,7 +139,8 @@ def generate_datetime_data_from_cldr(self, dt_json_path, run_limit=-1):
     def process_test_data(self):
         # Use NOde JS to create the .json files
         icu_nvm_versions = {
-            'icu76': '23.3.0',
+            'icu77': '24.0.0',
+            'icu76': '23.11.0',
             'icu75': '22.9.0',
             'icu74': '21.6.0',
             'icu73': '20.1.0',
diff --git a/testgen/generators/list_fmt.py b/testgen/generators/list_fmt.py
@@ -6,17 +6,15 @@
 import subprocess
 from generators.base import DataGenerator
 
-reblankline = re.compile("^\s*$")
-
 class ListFmtGenerator(DataGenerator):
     json_test = {"test_type": "list_fmt"}
     json_verify = {"test_type": "list_fmt"}
 
     def process_test_data(self):
         # Use Node JS to create the .json files
         icu_nvm_versions = {
-            'icu77': '23.10.0',  # Does not include ICU77 yet!
-            'icu76': '23.3.0',
+            'icu77': '24.0.0',
+            'icu76': '23.11.0',
             'icu75': '22.9.0',
             'icu74': '21.6.0',
             'icu73': '20.1.0',
diff --git a/testgen/generators/relativedatetime_fmt.py b/testgen/generators/relativedatetime_fmt.py
@@ -6,7 +6,6 @@
 import subprocess
 from generators.base import DataGenerator
 
-reblankline = re.compile("^\s*$")
 
 class RelativeDateTimeFmtGenerator(DataGenerator):
     json_test = {"test_type": "rdt_fmt"}
@@ -15,7 +14,7 @@ class RelativeDateTimeFmtGenerator(DataGenerator):
     def process_test_data(self):
         # Use NOde JS to create the .json files
         icu_nvm_versions = {
-            'icu77': '23.10.0',   # NOT YET AVAILABLE
+            'icu77': '24.0.0',
             'icu76': '23.3.0',
             'icu75': '22.9.0',
             'icu74': '21.6.0',
diff --git a/testgen/testdata_gen.py b/testgen/testdata_gen.py
@@ -17,8 +17,6 @@
 from generators.plurals import PluralGenerator
 from generators.relativedatetime_fmt import RelativeDateTimeFmtGenerator
 
-reblankline = re.compile("^\s*$")
-
 
 def setupArgs():
     parser = argparse.ArgumentParser(prog="testdata_gen")
