-
Notifications
You must be signed in to change notification settings - Fork 220
End to End implementation for Sliced Units For Core & Outlier #6889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `preferences` module in `cldr_serde/units` for handling unit preferences. - Added `unitPreferenceData.json` file to the test data, containing structured unit preference information. - Updated relevant modules to include the new `preferences` module and its functionality. - Enhanced `SourceDataProvider` to include unit preference data in the test setup.
- Introduced various new JSON files for unit lengths (e.g., centimeter, foot, mile) across multiple languages. - Added new modules for categorized display names and updated existing modules to include these new data structures. - Enhanced the `SourceDataProvider` to support the new unit length data and ensure proper integration with existing functionality.
- Introduced new JSON files for various units of length and mass (e.g., long-meter, short-kilogram) across multiple languages. - Removed outdated JSON files for certain units (e.g., long-foot, narrow-pound) to streamline the dataset. - Updated related modules to ensure compatibility with the new data structures and maintain functionality.
- Introduced new JSON files for volume units (e.g., core, extended, outlier) across multiple languages. - Updated the `categorized_display_name` module to include new volume unit display names. - Enhanced the `SourceDataProvider` to support the new volume unit data and ensure proper integration with existing functionality.
…unit markers - Updated the `CategorizedFormatter` to utilize separate data markers for core, extended, and outlier units. - Introduced new methods for creating formatters with extended and outlier data. - Enhanced the `MeasureUnitCategory` trait to define additional data markers for each unit category. - Updated tests to validate the new formatter functionality across different locales and unit types.
- Deleted the `UnitsNameVolumeExtendedV1` and its associated data files across various modules. - Updated the `CategorizedFormatter` and `MeasureUnitCategory` to reflect the removal of extended volume units. - Cleaned up related JSON files for volume units to streamline the dataset and ensure compatibility with existing functionality.
- Added support for `DataMarkerOutlier` in the `CategorizedFormatter` struct. - Refactored the `try_new_outlier` method to `try_outlier_new` for clarity. - Introduced a new helper function, `extract_needed_data`, to streamline data extraction for formatter constructors. - Updated plural rules initialization to use `try_new_cardinal`. - Enhanced tests to validate the new outlier formatter functionality across different locales.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.