Fix RB tree position

justcoding121 · justcoding121 · commit edb0809beb7e · 2018-12-25T13:48:02.000-05:00
diff --git a/src/Advanced.Algorithms/DataStructures/Tree/RedBlackTree.cs b/src/Advanced.Algorithms/DataStructures/Tree/RedBlackTree.cs
@@ -146,7 +146,7 @@ private RedBlackTreeNode<T> find(T value)
         public int Insert(T value)
         {
             var node = InsertAndReturnNode(value);
-            return node.Position;
+            return Root.Position(value);
         }
 
         /// <summary>
@@ -361,7 +361,7 @@ public int Delete(T value)
                 return -1;
             }
 
-            var position = node.Position;
+            var position = Root.Position(value);
 
             delete(node);
 
diff --git a/src/Advanced.Algorithms/DataStructures/Tree/Shared/BSTNodeBase.cs b/src/Advanced.Algorithms/DataStructures/Tree/Shared/BSTNodeBase.cs
@@ -10,9 +10,6 @@ internal abstract class BSTNodeBase<T> where T : IComparable
         //Used to fasten kth smallest computation.
         internal int Count { get; set; } = 1;
 
-        //position of this node in sorted order of containing BST
-        internal int Position => Left == null ? 0 : Left.Count;
-
         internal virtual BSTNodeBase<T> Parent { get; set; }
 
         internal virtual BSTNodeBase<T> Left { get; set; }

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ private RedBlackTreeNode<T> find(T value)`
`146`	`146`	`public int Insert(T value)`
`147`	`147`	`{`
`148`	`148`	`var node = InsertAndReturnNode(value);`
`149`		`- return node.Position;`
	`149`	`+ return Root.Position(value);`
`150`	`150`	`}`
`151`	`151`
`152`	`152`	`/// <summary>`
`@@ -361,7 +361,7 @@ public int Delete(T value)`
`361`	`361`	`return -1;`
`362`	`362`	`}`
`363`	`363`
`364`		`- var position = node.Position;`
	`364`	`+ var position = Root.Position(value);`
`365`	`365`
`366`	`366`	`delete(node);`
`367`	`367`