WorkerPool :: added missing return type & strict comparison

atakde · atakde · commit b2d6414f816f · 2022-06-30T00:54:32.000+03:00
diff --git a/Creational/Pool/WorkerPool.php b/Creational/Pool/WorkerPool.php
@@ -20,7 +20,7 @@ class WorkerPool implements Countable
 
     public function get(): StringReverseWorker
     {
-        if (count($this->freeWorkers) == 0) {
+        if (count($this->freeWorkers) === 0) {
             $worker = new StringReverseWorker();
         } else {
             $worker = array_pop($this->freeWorkers);
@@ -31,10 +31,9 @@ public function get(): StringReverseWorker
         return $worker;
     }
 
-    public function dispose(StringReverseWorker $worker)
+    public function dispose(StringReverseWorker $worker): void
     {
         $key = spl_object_hash($worker);
-
         if (isset($this->occupiedWorkers[$key])) {
             unset($this->occupiedWorkers[$key]);
             $this->freeWorkers[$key] = $worker;

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ class WorkerPool implements Countable`
`20`	`20`
`21`	`21`	`public function get(): StringReverseWorker`
`22`	`22`	`{`
`23`		`- if (count($this->freeWorkers) == 0) {`
	`23`	`+ if (count($this->freeWorkers) === 0) {`
`24`	`24`	`$worker = new StringReverseWorker();`
`25`	`25`	`} else {`
`26`	`26`	`$worker = array_pop($this->freeWorkers);`
`@@ -31,10 +31,9 @@ public function get(): StringReverseWorker`
`31`	`31`	`return $worker;`
`32`	`32`	`}`
`33`	`33`
`34`		`- public function dispose(StringReverseWorker $worker)`
	`34`	`+ public function dispose(StringReverseWorker $worker): void`
`35`	`35`	`{`
`36`	`36`	`$key = spl_object_hash($worker);`
`37`		`-`
`38`	`37`	`if (isset($this->occupiedWorkers[$key])) {`
`39`	`38`	`unset($this->occupiedWorkers[$key]);`
`40`	`39`	`$this->freeWorkers[$key] = $worker;`