Merge pull request #10 from video-db/0.0.4.post

ashish-spext · web-flow · commit 98d0a237bd3d · 2024-02-27T17:07:50.000+05:30
0.0.5a1
diff --git a/setup.py b/setup.py
@@ -28,7 +28,7 @@ def get_version():
     long_description_content_type="text/markdown",
     url="https://github.com/video-db/videodb-python",
     packages=find_packages(exclude=["tests", "tests.*"]),
-    python_requires=">=3.9",
+    python_requires=">=3.8",
     install_requires=[
         "requests>=2.25.1",
         "backoff>=2.2.1",
@@ -37,6 +37,11 @@ def get_version():
     classifiers=[
         "Intended Audience :: Developers",
         "Programming Language :: Python :: 3",
+        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
+        "Programming Language :: Python :: 3.10",
+        "Programming Language :: Python :: 3.11",
+        "Programming Language :: Python :: 3.12",
+        "License :: OSI Approved :: Apache Software License",
     ],
 )
diff --git a/videodb/__init__.py b/videodb/__init__.py
@@ -23,7 +23,7 @@
 
 logger: logging.Logger = logging.getLogger("videodb")
 
-__version__ = "0.0.4"
+__version__ = "0.0.5a1"
 __author__ = "videodb"
 
 __all__ = [
diff --git a/videodb/collection.py b/videodb/collection.py
@@ -69,12 +69,12 @@ def delete_image(self, image_id: str) -> None:
     def search(
         self,
         query: str,
-        type: Optional[str] = SearchType.semantic,
+        search_type: Optional[str] = SearchType.semantic,
         result_threshold: Optional[int] = None,
         score_threshold: Optional[int] = None,
         dynamic_score_percentage: Optional[int] = None,
     ) -> SearchResult:
-        search = SearchFactory(self._connection).get_search(type)
+        search = SearchFactory(self._connection).get_search(search_type)
         return search.search_inside_collection(
             self.id,
             query,
diff --git a/videodb/search.py b/videodb/search.py
@@ -172,7 +172,7 @@ def search_inside_video(
         )
         return SearchResult(self._connection, **search_data)
 
-    def search_inside_collection(**kwargs):
+    def search_inside_collection(self, **kwargs):
         raise NotImplementedError("Keyword search will be implemented in the future")
 
 

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ def search_inside_video(`
`172`	`172`	`)`
`173`	`173`	`return SearchResult(self._connection, **search_data)`
`174`	`174`
`175`		`- def search_inside_collection(**kwargs):`
	`175`	`+ def search_inside_collection(self, **kwargs):`
`176`	`176`	`raise NotImplementedError("Keyword search will be implemented in the future")`
`177`	`177`
`178`	`178`