fix: remove SceneExtractionConfig

ankit-v2-3 · ankit-v2-3 · commit ba4f07ec80a0 · 2024-06-13T15:35:38.000+05:30
diff --git a/videodb/scene.py b/videodb/scene.py
@@ -5,29 +5,6 @@
 from videodb.image import Frame
 
 
-class SceneExtractionConfig:
-    def __init__(
-        self,
-        time: int = 5,
-        threshold: int = 20,
-        frame_count: int = 1,
-        select_frame: str = "first",
-    ):
-        self.time = time
-        self.threshold = threshold
-        self.frame_count = frame_count
-        self.select_frame = select_frame
-
-    def __repr__(self) -> str:
-        return (
-            f"SceneExtractionConfig("
-            f"time={self.time}, "
-            f"threshold={self.threshold}, "
-            f"frame_count={self.frame_count}, "
-            f"select_frame={self.select_frame})"
-        )
-
-
 class Scene:
     def __init__(
         self,
@@ -73,21 +50,21 @@ def __init__(
         _connection,
         id: str,
         video_id: str,
-        config: SceneExtractionConfig,
+        config: dict,
         scenes: List[Scene],
     ) -> None:
         self._connection = _connection
         self.id = id
         self.video_id = video_id
-        self.config: SceneExtractionConfig = config
+        self.config: dict = config
         self.scenes: List[Scene] = scenes
 
     def __repr__(self) -> str:
         return (
             f"SceneCollection("
             f"id={self.id}, "
             f"video_id={self.video_id}, "
-            f"config={self.config.__dict__}, "
+            f"config={self.config}, "
             f"scenes={self.scenes})"
         )
 
diff --git a/videodb/video.py b/videodb/video.py
@@ -9,7 +9,7 @@
     Workflows,
 )
 from videodb.image import Image, Frame
-from videodb.scene import SceneExtractionConfig, Scene, SceneCollection
+from videodb.scene import Scene, SceneCollection
 from videodb.search import SearchFactory, SearchResult
 from videodb.shot import Shot
 
@@ -213,25 +213,18 @@ def _format_scene_collection(self, collection_data: dict) -> SceneCollection:
             )
             scenes.append(scene)
 
-        config = collection_data.get("config", {})
-
         return SceneCollection(
             self._connection,
             collection_data.get("scenes_collection_id"),
             self.id,
-            SceneExtractionConfig(
-                config.get("time"),
-                config.get("threshold"),
-                config.get("frame_count"),
-                config.get("select_frame"),
-            ),
+            collection_data.get("config", {}),
             scenes,
         )
 
     def extract_scenes(
         self,
         extraction_type: SceneExtractionType = SceneExtractionType.scene,
-        extraction_config: SceneExtractionConfig = SceneExtractionConfig(),
+        extraction_config: dict = {},
         force: bool = False,
         callback_url: str = None,
     ):
@@ -240,7 +233,7 @@ def extract_scenes(
             data={
                 "index_type": IndexType.scene,
                 "extraction_type": extraction_type,
-                "extraction_config": extraction_config.__dict__,
+                "extraction_config": extraction_config,
                 "force": force,
                 "callback_url": callback_url,
             },
@@ -267,7 +260,7 @@ def delete_scene_collection(self, collection_id: str) -> None:
     def create_scene_index(
         self,
         extraction_type: SceneExtractionType = SceneExtractionType.scene,
-        extraction_config: SceneExtractionConfig = SceneExtractionConfig(),
+        extraction_config: dict = {},
         scenes: List[Scene] = [],
         force: bool = False,
         callback_url: str = None,
@@ -277,7 +270,7 @@ def create_scene_index(
             data={
                 "scenes": [scene.to_json() for scene in scenes],
                 "extraction_type": extraction_type,
-                "extraction_config": extraction_config.__dict__,
+                "extraction_config": extraction_config,
                 "force": force,
                 "callback_url": callback_url,
             },
