added kostyl for page resource disposal during page.close

vsmetansky · vsmetansky · commit cbb48dced470 · 2020-11-05T16:06:24.000+02:00
diff --git a/playwright/page.py b/playwright/page.py
@@ -559,10 +559,22 @@ async def screenshot(
     async def title(self) -> str:
         return await self._main_frame.title()
 
+    # async def close(self, runBeforeUnload: bool = None) -> None:
+    #     await self._channel.send("close", locals_to_params(locals()))
+    #     if self._owned_context:
+    #         await self._owned_context.close()
+
     async def close(self, runBeforeUnload: bool = None) -> None:
         await self._channel.send("close", locals_to_params(locals()))
         if self._owned_context:
             await self._owned_context.close()
+        self._dispose()
+
+    def _dispose(self) -> None:
+        objs_to_remove = ['Response', 'Request', 'ElementHandle', 'Frame', 'ConsoleMessage', 'JSHandle']
+        for k in tuple(filter(lambda k: any(o in k for o in objs_to_remove), self._connection._objects)):
+            self._connection._objects[k]._dispose()
+        super()._dispose()
 
     def isClosed(self) -> bool:
         return self._is_closed
