Skip to content

Better event argument types #13796

@jimmylab

Description

@jimmylab

// form events
onChange: Event
onBeforeinput: Event
onInput: Event
onReset: Event
onSubmit: Event
onInvalid: Event
// image events
onLoad: Event
onError: Event
// keyboard events
onKeydown: KeyboardEvent
onKeypress: KeyboardEvent
onKeyup: KeyboardEvent
// mouse events
onAuxclick: MouseEvent
onClick: MouseEvent
onContextmenu: MouseEvent
onDblclick: MouseEvent
onMousedown: MouseEvent
onMouseenter: MouseEvent
onMouseleave: MouseEvent
onMousemove: MouseEvent
onMouseout: MouseEvent
onMouseover: MouseEvent
onMouseup: MouseEvent
// media events
onAbort: Event
onCanplay: Event
onCanplaythrough: Event
onDurationchange: Event
onEmptied: Event
onEncrypted: Event
onEnded: Event
onLoadeddata: Event
onLoadedmetadata: Event
onLoadstart: Event
onPause: Event
onPlay: Event
onPlaying: Event
onProgress: Event

@@ -1296,15 +1296,15 @@

   // form events
   onChange: Event
-  onBeforeinput: Event
+  onBeforeinput: InputEvent
   onInput: Event
   onReset: Event
-  onSubmit: Event
+  onSubmit: SubmitEvent
   onInvalid: Event

   // image events
   onLoad: Event
-  onError: Event
+  onError: ErrorEvent

   // keyboard events
   onKeydown: KeyboardEvent
@@ -1312,9 +1312,9 @@
   onKeyup: KeyboardEvent

   // mouse events
-  onAuxclick: MouseEvent
-  onClick: MouseEvent
-  onContextmenu: MouseEvent
+  onAuxclick: PointerEvent
+  onClick: PointerEvent
+  onContextmenu: PointerEvent
   onDblclick: MouseEvent
   onMousedown: MouseEvent
   onMouseenter: MouseEvent
@@ -1325,7 +1325,7 @@
   onMouseup: MouseEvent

   // media events
-  onAbort: Event
+  onAbort: UIEvent
   onCanplay: Event
   onCanplaythrough: Event
   onDurationchange: Event
@@ -1338,7 +1338,7 @@
   onPause: Event
   onPlay: Event
   onPlaying: Event
-  onProgress: Event
+  onProgress: ProgressEvent
   onRatechange: Event
   onSeeked: Event
   onSeeking: Event

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions