Update documentation and clean up code

tneotia · tneotia · commit 426c85d4fd75 · 2021-02-08T17:55:44.000-05:00
diff --git a/README.md b/README.md
@@ -86,6 +86,8 @@ A Flutter widget for rendering HTML and CSS as Flutter widgets.
   - [SVG](#svg)
   
   - [Table](#table)
+  
+- [Notes](#notes)
 
 - [Migration Guide](#migration-guides)
 
@@ -102,12 +104,13 @@ Add the following to your `pubspec.yaml` file:
 |            |           |       |             |         |         |       |      |        |        |        |
 |------------|-----------|-------|-------------|---------|---------|-------|------|--------|--------|--------|
 |`a`         | `abbr`    | `acronym`| `address`   | `article`| `aside` | `audio`| `b`  | `bdi`  | `bdo`  | `big`  |
-|`blockquote`| `body`    | `br`  | `caption`   | `cite`  | `code`  | `data`| `dd` | `del`  | `dfn`  | `div`  |
-|`dl`        | `dt`      | `em`  | `figcaption`| `figure`| `footer`| `h1`  | `h2` | `h3`   | `h4`   | `h5`   |
-|`h6`        | `header`  | `hr`  | `i`         | `iframe`| `img`   | `ins` | `kbd`| `li`   | `main` | `mark` |
-|`nav`       | `noscript`|`ol`   | `p`         | `pre`   | `q`     | `rp`  | `rt` | `ruby` | `s`    |`samp`  |
-|`section`   | `small`   | `span`| `strike`    | `strong`| `sub`   | `sup` | `svg`| `table`| `tbody`| `td`   |
-| `template` | `tfoot`   | `th`  | `thead`     |`time`   | `tr`    | `tt`  | `u`  | `ul`   | `var`  | `video`|
+|`blockquote`| `body`    | `br`  | `caption`   | `cite`  | `code`  | `data`| `dd` | `del`  | `details`  | `dfn`  |
+| `div` | `dl`        | `dt`      | `em`  | `figcaption`| `figure`| `footer`| `h1`  | `h2` | `h3`   | `h4`   |
+| `h5` |`h6`        | `header`  | `hr`  | `i`         | `iframe`| `img`   | `ins` | `kbd`| `li`   | `main` | 
+| `mark` | `nav`       | `noscript`|`ol`   | `p`         | `pre`   | `q`     | `rp`  | `rt` | `ruby` | `s`  |
+| `samp` | `section`   | `small`   | `span`| `strike`    | `strong`| `sub`   | `sup` | `summary` | `svg`| `table`| 
+| `tbody` | `td` | `template` | `tfoot`   | `th`  | `thead`     |`time`   | `tr`    | `tt`  | `u`  | `ul` |
+| `var` | `video` |    |   |      |   |     |   |   |    |   | 
 
 
  
@@ -640,6 +643,24 @@ This package renders table elements using the [`flutter_layout_grid`](https://pu
 
 When rendering table elements, the package tries to calculate the best fit for each element and size its cell accordingly. `Rowspan`s and `colspan`s are considered in this process, so cells that span across multiple rows and columns are rendered as expected. Heights are determined intrinsically to maintain an optimal aspect ratio for the cell.
 
+## Notes
+
+1. If you'd like to use this widget inside of a `Row()`, make sure to set `shrinkWrap: true` and place your widget inside expanded:
+
+```dart
+Widget row = Row(
+   children: [
+	Expanded(
+	    child: Html(
+          shrinkWrap: true,
+          //other params
+        )
+	),
+	//whatever other widgets
+   ]
+);
+```
+
 ## Migration Guides
 - For Version 1.0 - [Guide](https://github.com/Sub6Resources/flutter_html/wiki/1.0.0-Migration-Guide)
 
diff --git a/lib/html_parser.dart b/lib/html_parser.dart
@@ -68,7 +68,6 @@ class HtmlParser extends StatelessWidget {
       RenderContext(
         buildContext: context,
         parser: this,
-        style: Style.fromTextStyle(Theme.of(context).textTheme.bodyText2),
       ),
       cleanedTree,
     );
@@ -789,8 +788,7 @@ class StyledText extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     return SizedBox(
-      width: (style.display == Display.BLOCK || style.display == Display.LIST_ITEM) && renderContext.parser.shrinkWrap != true
-        ? double.infinity : renderContext.parser.shrinkWrap == true ? MediaQuery.of(renderContext.buildContext).size.width : null,
+      width: calculateWidth(style.display, renderContext),
       child: Text.rich(
         textSpan,
         style: style.generateTextStyle(),
@@ -800,4 +798,14 @@ class StyledText extends StatelessWidget {
       ),
     );
   }
+
+  double calculateWidth(Display display, RenderContext context) {
+    if ((display == Display.BLOCK || display == Display.LIST_ITEM) && renderContext.parser.shrinkWrap != true) {
+      return double.infinity;
+    } else if (renderContext.parser.shrinkWrap == true) {
+      return MediaQuery.of(context.buildContext).size.width;
+    } else {
+      return null;
+    }
+  }
 }
diff --git a/lib/src/layout_element.dart b/lib/src/layout_element.dart
@@ -285,6 +285,7 @@ class DetailsContentElement extends LayoutElement {
             children: [firstChild] ?? [],
           ),
           style: style,
+          renderContext: context,
         ) : Text("Details"),
         children: [
           StyledText(
@@ -293,6 +294,7 @@ class DetailsContentElement extends LayoutElement {
               children: getChildren(childrenList, context, elementList?.isNotEmpty == true && elementList?.first?.localName == "summary" ? firstChild : null)
             ),
             style: style,
+            renderContext: context,
           ),
         ]
     );
