Skip to content

Commit 9c1b949

Browse files
committed
Fix a bug where DefaultChannelPipelineTest.testFireChannelRegistered() triggers channelRegistered() twice
1 parent 1a54ff8 commit 9c1b949

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,8 +189,9 @@ public void testChannelHandlerContextNavigation() {
189189

190190
@Test
191191
public void testFireChannelRegistered() throws Exception {
192-
ChannelPipeline pipeline = new LocalChannel(group.next()).pipeline();
193192
final CountDownLatch latch = new CountDownLatch(1);
193+
Channel ch = new LocalChannel(group.next());
194+
ChannelPipeline pipeline = ch.pipeline();
194195
pipeline.addLast(new ChannelInitializer<Channel>() {
195196
@Override
196197
protected void initChannel(Channel ch) throws Exception {
@@ -202,7 +203,7 @@ public void channelRegistered(ChannelHandlerContext ctx) throws Exception {
202203
});
203204
}
204205
});
205-
pipeline.fireChannelRegistered();
206+
ch.unsafe().register(ch.newPromise());
206207
assertTrue(latch.await(2, TimeUnit.SECONDS));
207208
}
208209

0 commit comments

Comments
 (0)