✨ Feature: make GitUser's date field to be date-time (#201)

yanyongyu · web-flow · commit 87d31fe47f9f · 2025-04-06T17:03:23.000+08:00
diff --git a/githubkit/versions/ghec_v2022_11_28/models/group_0261.py b/githubkit/versions/ghec_v2022_11_28/models/group_0261.py
@@ -9,6 +9,8 @@
 
 from __future__ import annotations
 
+from datetime import datetime
+
 from pydantic import Field
 
 from githubkit.compat import GitHubModel, model_rebuild
@@ -24,7 +26,7 @@ class GitUser(GitHubModel):
 
     name: Missing[str] = Field(default=UNSET)
     email: Missing[str] = Field(default=UNSET)
-    date: Missing[str] = Field(default=UNSET)
+    date: Missing[datetime] = Field(default=UNSET)
 
 
 model_rebuild(GitUser)
diff --git a/githubkit/versions/ghec_v2022_11_28/types/group_0261.py b/githubkit/versions/ghec_v2022_11_28/types/group_0261.py
@@ -9,6 +9,7 @@
 
 from __future__ import annotations
 
+from datetime import datetime
 from typing_extensions import NotRequired, TypedDict
 
 
@@ -20,7 +21,7 @@ class GitUserType(TypedDict):
 
     name: NotRequired[str]
     email: NotRequired[str]
-    date: NotRequired[str]
+    date: NotRequired[datetime]
 
 
 __all__ = ("GitUserType",)
diff --git a/githubkit/versions/v2022_11_28/models/group_0221.py b/githubkit/versions/v2022_11_28/models/group_0221.py
@@ -9,6 +9,8 @@
 
 from __future__ import annotations
 
+from datetime import datetime
+
 from pydantic import Field
 
 from githubkit.compat import GitHubModel, model_rebuild
@@ -24,7 +26,7 @@ class GitUser(GitHubModel):
 
     name: Missing[str] = Field(default=UNSET)
     email: Missing[str] = Field(default=UNSET)
-    date: Missing[str] = Field(default=UNSET)
+    date: Missing[datetime] = Field(default=UNSET)
 
 
 model_rebuild(GitUser)
diff --git a/githubkit/versions/v2022_11_28/types/group_0221.py b/githubkit/versions/v2022_11_28/types/group_0221.py
@@ -9,6 +9,7 @@
 
 from __future__ import annotations
 
+from datetime import datetime
 from typing_extensions import NotRequired, TypedDict
 
 
@@ -20,7 +21,7 @@ class GitUserType(TypedDict):
 
     name: NotRequired[str]
     email: NotRequired[str]
-    date: NotRequired[str]
+    date: NotRequired[datetime]
 
 
 __all__ = ("GitUserType",)
diff --git a/pyproject.toml b/pyproject.toml
@@ -348,6 +348,11 @@ source = "https://raw.githubusercontent.com/github/rest-api-description/main/des
   "null",
 ] }
 
+# https://github.com/yanyongyu/githubkit/issues/199
+# https://github.com/github/rest-api-description/issues/4697
+# git user date format should be date-time
+"/components/schemas/git-user/properties/date" = { format = "date-time" }
+
 # https://github.com/yanyongyu/githubkit/pull/134
 # blob_url and raw_url may be null when the diff file is submodule's file
 "/components/schemas/diff-entry/properties/blob_url" = { type = [
