Patch for an Issue sqlmapproject#193

stamparm · stamparm · commit fccdb824bbfa · 2012-09-25T11:21:39.000+02:00
diff --git a/lib/core/settings.py b/lib/core/settings.py
@@ -402,6 +402,9 @@
 # Skip unforced HashDB flush requests below the threshold number of cached items
 HASHDB_FLUSH_THRESHOLD = 32
 
+# Number of retries for unsuccessful HashDB flush attempts
+HASHDB_FLUSH_RETRIES = 3
+
 # Unique milestone value used for forced deprecation of old HashDB values (e.g. when changing hash/pickle mechanism)
 HASHDB_MILESTONE_VALUE = "cAWxkLYCQT"  # r5129 "".join(random.sample(string.letters, 10))
 
diff --git a/lib/utils/hashdb.py b/lib/utils/hashdb.py
@@ -14,6 +14,8 @@
 from lib.core.common import getUnicode
 from lib.core.common import serializeObject
 from lib.core.common import unserializeObject
+from lib.core.data import logger
+from lib.core.settings import HASHDB_FLUSH_RETRIES
 from lib.core.settings import HASHDB_FLUSH_THRESHOLD
 from lib.core.settings import UNICODE_ENCODING
 from lib.core.threads import getCurrentThreadData
@@ -95,16 +97,24 @@ def flush(self, forced=False):
         try:
             self.beginTransaction()
             for hash_, value in _.items():
+                retries = 0
                 while True:
                     try:
                         try:
                             self.cursor.execute("INSERT INTO storage VALUES (?, ?)", (hash_, value,))
                         except sqlite3.IntegrityError:
                             self.cursor.execute("UPDATE storage SET value=? WHERE id=?", (value, hash_,))
                     except sqlite3.OperationalError, ex:
-                        if not any(_ in ex.message for _ in ('locked', 'I/O')):
-                            raise
+
+                        if retries == 0:
+                            warnMsg = "there has been a problem while writing to "
+                            warnMsg += "the session file ('%s')" % ex.message
+                            logger.warn(warnMsg)
+
+                        if retries >= HASHDB_FLUSH_RETRIES:
+                            return
                         else:
+                            retries += 1
                             time.sleep(1)
                     else:
                         break
