There is no need for -initWithDelegate, -init and +javascriptBridge. Just use +javascriptBridgeWithDelegate

marcuswestin · marcuswestin · commit f0f9c98b1e84 · 2011-12-04T12:29:35.000-08:00
diff --git a/WebViewJavascriptBridge/Classes/WebViewJavascriptBridge.h b/WebViewJavascriptBridge/Classes/WebViewJavascriptBridge.h
@@ -10,24 +10,13 @@
 
 @interface WebViewJavascriptBridge : NSObject <UIWebViewDelegate>
 
-/* Delegate to receive messages from javascript.
- * Defined as IBOutlet for Interface Builder assignment */
 @property (nonatomic, assign) IBOutlet id <WebViewJavascriptBridgeDelegate> delegate;
 
-/* Init with a predefined delegate */
-- (id)initWithDelegate:(id <WebViewJavascriptBridgeDelegate>)delegate;
-
-/* Convenience methods for obtaining a bridge */
-+ (id)javascriptBridge;
+/* Create a javascript bridge with the given delegate for handling messages */
 + (id)javascriptBridgeWithDelegate:(id <WebViewJavascriptBridgeDelegate>)delegate;
 
-/* Sends message to given webView. You need to integrate javascript bridge into
- * this view before by calling WebViewJavascriptBridge#webViewDidFinishLoad: with that view.
- *
- * You can call this method before calling webViewDidFinishLoad: , then all messages
- * will be accumulated in _startupMessageQueue & sended to webView, provided by first
- * webViewDidFinishLoad: call.
- */
+/* Send a message to the web view. Make sure that this javascript bridge is the delegate
+ * of the webview before calling this method (see ExampleAppDelegate.m) */
 - (void)sendMessage:(NSString *)message toWebView:(UIWebView *)webView;
 
 @end
diff --git a/WebViewJavascriptBridge/Classes/WebViewJavascriptBridge.m b/WebViewJavascriptBridge/Classes/WebViewJavascriptBridge.m
@@ -18,25 +18,11 @@ @implementation WebViewJavascriptBridge
 static NSString *CUSTOM_PROTOCOL_SCHEME = @"webviewjavascriptbridge";
 static NSString *QUEUE_HAS_MESSAGE = @"queuehasmessage";
 
-- (id)initWithDelegate:(id <WebViewJavascriptBridgeDelegate>)delegate {
-    if ((self = [super init])) {
-        self.delegate = delegate;
-        self.startupMessageQueue = [[[NSMutableArray alloc] init] autorelease];
-    }
-
-    return self;
-}
-
-- (id)init {
-    return [[[WebViewJavascriptBridge alloc] initWithDelegate:nil] autorelease];
-}
-
 + (id)javascriptBridgeWithDelegate:(id <WebViewJavascriptBridgeDelegate>)delegate {
-    return [[[self alloc] initWithDelegate:delegate] autorelease];
-}
-
-+ (id)javascriptBridge {
-    return [[[self alloc] init] autorelease];
+    WebViewJavascriptBridge* bridge = [[[WebViewJavascriptBridge alloc] init] autorelease];
+    bridge.delegate = delegate;
+    bridge.startupMessageQueue = [[[NSMutableArray alloc] init] autorelease];
+    return bridge;
 }
 
 - (void)dealloc {
