refactor: remove magic strings

DanielleMaywood · DanielleMaywood · commit 6e14061eb86e · 2025-08-11T14:22:08.000Z
diff --git a/coderd/aitasks.go b/coderd/aitasks.go
@@ -110,7 +110,7 @@ func (api *API) aiTasksCreate(rw http.ResponseWriter, r *http.Request) {
 	}
 	if !hasAIPrompt {
 		httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
-			Message: `Template does not have required parameter "AI Prompt"`,
+			Message: `Template does not have required parameter "` + codersdk.AITaskPromptParameterName + `"`,
 		})
 		return
 	}
@@ -120,7 +120,7 @@ func (api *API) aiTasksCreate(rw http.ResponseWriter, r *http.Request) {
 		TemplateVersionID:       req.TemplateVersionID,
 		TemplateVersionPresetID: req.TemplateVersionPresetID,
 		RichParameterValues: []codersdk.WorkspaceBuildParameter{
-			{Name: "AI Prompt", Value: req.Prompt},
+			{Name: codersdk.AITaskPromptParameterName, Value: req.Prompt},
 		},
 	}
 
diff --git a/coderd/aitasks_test.go b/coderd/aitasks_test.go
@@ -191,7 +191,7 @@ func TestAITasksCreate(t *testing.T) {
 		parameters, err := client.WorkspaceBuildParameters(ctx, workspace.LatestBuild.ID)
 		require.NoError(t, err)
 		require.Len(t, parameters, 1)
-		assert.Equal(t, "AI Prompt", parameters[0].Name)
+		assert.Equal(t, codersdk.AITaskPromptParameterName, parameters[0].Name)
 		assert.Equal(t, taskPrompt, parameters[0].Value)
 	})
 

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ func (api API) aiTasksCreate(rw http.ResponseWriter, r http.Request) {`
`110`	`110`	`}`
`111`	`111`	`if !hasAIPrompt {`
`112`	`112`	`httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{`
`113`		- Message: `Template does not have required parameter "AI Prompt"`,
	`113`	+ Message: `Template does not have required parameter "` + codersdk.AITaskPromptParameterName + `"`,
`114`	`114`	`})`
`115`	`115`	`return`
`116`	`116`	`}`
`@@ -120,7 +120,7 @@ func (api API) aiTasksCreate(rw http.ResponseWriter, r http.Request) {`
`120`	`120`	`TemplateVersionID: req.TemplateVersionID,`
`121`	`121`	`TemplateVersionPresetID: req.TemplateVersionPresetID,`
`122`	`122`	`RichParameterValues: []codersdk.WorkspaceBuildParameter{`
`123`		`- {Name: "AI Prompt", Value: req.Prompt},`
	`123`	`+ {Name: codersdk.AITaskPromptParameterName, Value: req.Prompt},`
`124`	`124`	`},`
`125`	`125`	`}`
`126`	`126`