feat(coderd): add support for external agents to API's and provisioner #19286
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
b641ffe to
07a9c42
Compare
c012284 to
63fefbb
Compare
60cccc2 to
0cf5381
Compare
| t.Run("OK Linux", func(t *testing.T) { | ||
| t.Parallel() | ||
| client := coderdtest.New(t, nil) | ||
| script, err := client.InitScript(context.Background(), "linux", "amd64") |
There was a problem hiding this comment.
Probably should make one of these arm64 for variety, and also assert that the string /bin/coder-OS-ARCH[.exe] shows up
enterprise/coderd/coderd.go
Outdated
| @@ -943,6 +952,18 @@ func (api *API) CheckBuildUsage(ctx context.Context, store database.Store, templ | |||
| // When there are no licenses installed, a noop usage checker is used | |||
| // instead. | |||
There was a problem hiding this comment.
Dude to this comment above (and the entitlements code in the function above), external agents won't be blocked if there are no licenses installed (e.g. an enterprise build in free mode). Is that what you want? If it's not, I can walk you through a few changes to fix this.
63fefbb to
6033188
Compare
4e94ed6 to
5a0bf15
Compare
| @@ -223,6 +223,7 @@ func Workspaces(ctx context.Context, db database.Store, query string, page coder | |||
| Valid: values.Has("outdated"), | |||
| } | |||
| filter.HasAITask = parser.NullableBoolean(values, sql.NullBool{}, "has-ai-task") | |||
There was a problem hiding this comment.
Can you also file a ticket to fix has-ai-task?
| Message: "Workspace does not have an external agent.", | ||
| }) | ||
| return | ||
| } |
There was a problem hiding this comment.
This is good but I still think the specific agent should be checked as well.
| @@ -180,6 +180,8 @@ type Options struct { | |||
| // Entitlements can come from the enterprise caller if enterprise code is | |||
| // included. | |||
| Entitlements *entitlements.Set | |||
| // HasLicense indicates if a license is installed. | |||
There was a problem hiding this comment.
This should just be a field on entitlements.Set if possible.
This pull request introduces support for external workspace management, allowing users to register and manage workspaces that are provisioned and managed outside of the Coder.
Depends on: coder/terraform-provider-coder#424