Skip to content

Add version constructor #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Aug 9, 2022
Merged

Add version constructor #179

merged 0 commits into from
Aug 9, 2022

Conversation

kazhuravlev
Copy link
Contributor

@kazhuravlev kazhuravlev commented Aug 1, 2022 •
edited
Loading

This New function is helpful for code like that

versions := []string{
  "v0.1.0",
  "v0.4.0",
}

maxVersion := semver.New(0, 0, 0, "", "")
for _, version := range versions{
  v, _ := semver.NewVersion(version)
  if v.GreaterThan(maxVersion) {
    maxVersion = v
  }
}

fmt.Println(maxVersion)

@kazhuravlev
Copy link
Contributor Author

@mattfarina I merge origin to my PR. Workflow green now. Please, re-run the workflow in this PR.

@mattfarina mattfarina merged commit bfa99d9 into Masterminds:master Aug 9, 2022
@mattfarina
Copy link
Member

I added a test for the New function and merged. Will be in the next release.

This was referenced Apr 7, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazhuravlev @mattfarina