Skip to content

Support Import Assertions for re-export statement #12249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 26, 2020
Merged

Support Import Assertions for re-export statement #12249

merged 8 commits into from
Oct 26, 2020

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Oct 24, 2020 •
edited by gitpod-io bot
Loading

Q                       A
Fixed Issues? Fixes #12248
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@sosukesuzuki sosukesuzuki added pkg: generator pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Import Attributes labels Oct 24, 2020
@babel-bot
Copy link
Collaborator

babel-bot commented Oct 24, 2020 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/31011/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 24, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dd4b991:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

nicolo-ribaudo
nicolo-ribaudo reviewed Oct 24, 2020
View reviewed changes
JLHwung
JLHwung reviewed Oct 24, 2020
View reviewed changes
packages/babel-parser/src/parser/statement.js
const assertions = this.maybeParseImportAssertions();
if (assertions) {
// $FlowIgnore
node.assertions = assertions;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add type information to packages/babel-parser/src/types.js.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fa83ccb 👍

nicolo-ribaudo
nicolo-ribaudo approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit faaebfe into babel:main Oct 26, 2020
@sosukesuzuki sosukesuzuki deleted the fix-12248 branch October 26, 2020 14:50
@JLHwung JLHwung mentioned this pull request Oct 27, 2020
Merged
@sosukesuzuki sosukesuzuki mentioned this pull request Nov 4, 2020
Merged
sosukesuzuki added a commit to prettier/prettier that referenced this pull request Nov 6, 2020
@sosukesuzuki
Add test for babel/babel#12249
08193c5
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung left review comments

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Import Attributes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import Assertions for re-export statement is not allowed
5 participants
@sosukesuzuki @babel-bot @existentialism @JLHwung @nicolo-ribaudo