Add parser support for the "regexp unicode sets" proposal #14086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50478/ |
JLHwung
approved these changes
Dec 30, 2021
existentialism
approved these changes
Dec 31, 2021
mathiasbynens
approved these changes
Dec 31, 2021
9 tasks
2 tasks
nicolo-ribaudo
added a commit
that referenced
this pull request
Dec 31, 2021
nicolo-ribaudo
added a commit
that referenced
this pull request
Jan 8, 2022
nicolo-ribaudo
added a commit
that referenced
this pull request
Jan 10, 2022
nicolo-ribaudo
added a commit
that referenced
this pull request
Jan 18, 2022
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 1, 2022
This was referenced Feb 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements parser support for https://github.com/tc39/proposal-regexp-set-notation/. Actually, most of the work was done in jviereck/regjsparser#113 and we just need to update
@babel/parserto accept thevflag.The proposal is the result of merging two proposals, and it's name is quite long (RegExp set notation + properties of strings). I used
regexpUnicodeSetsflag as the parser plugin name because thevflag is calledunicodeSets.I'll merge this PR to a feature branch so that I can then open another one to create the transform plugin (based on https://github.com/mathiasbynens/regexpu-core/). I have already done most of the work in the various regexp packages, we only need to wire it to Babel.
cc @mathiasbynens