Skip to content

Configure convertDeprecationsToExceptions="true" in phpunit.xml.dist #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 13, 2022
Merged

Configure convertDeprecationsToExceptions="true" in phpunit.xml.dist #2992

merged 3 commits into from
Mar 13, 2022

Conversation

TimWolla
Copy link
Contributor

@TimWolla TimWolla commented Mar 4, 2022

No description provided.

@TimWolla
Copy link
Contributor Author

TimWolla commented Mar 4, 2022

see also: php-http/client-integration-tests#57.

@TimWolla TimWolla marked this pull request as ready for review March 4, 2022 10:22
@TimWolla TimWolla mentioned this pull request Mar 4, 2022
Merged
GrahamCampbell
GrahamCampbell requested changes Mar 7, 2022
View reviewed changes
@TimWolla TimWolla force-pushed the phpunit-deprecation branch from 46e408f to 74c7f6f Compare March 7, 2022 12:05
@TimWolla TimWolla requested a review from GrahamCampbell March 7, 2022 12:07
GrahamCampbell
GrahamCampbell requested changes Mar 7, 2022
View reviewed changes
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing.

@TimWolla TimWolla force-pushed the phpunit-deprecation branch from 9588562 to 5f49aa2 Compare March 7, 2022 12:18
@TimWolla
Copy link
Contributor Author

TimWolla commented Mar 7, 2022

Dang, sorry for that noise. I should've waited for all jobs to finish, instead of just the PHPUnit ones. Now fixed.

@TimWolla TimWolla requested a review from GrahamCampbell March 7, 2022 12:20
@GrahamCampbell GrahamCampbell requested a review from Nyholm March 7, 2022 16:28
@GrahamCampbell GrahamCampbell merged commit d12ecb1 into guzzle:master Mar 13, 2022
@TimWolla TimWolla deleted the phpunit-deprecation branch March 13, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

@Nyholm Nyholm Awaiting requested review from Nyholm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimWolla @GrahamCampbell