allow private parse method in response middleware #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMacTia
requested changes
Feb 7, 2020
There was a problem hiding this comment.
Although I'm not entirely sure as why someone would want to define the parse method as private, I have nothing against it in principle, so happy to merge this in.
I do, however, not entirely like the unnecessary line I commented on below, and would prefer to take it out before merging.
|
change as you required. Let me know if you have anything else that does not convince you. |
olleolleolle
approved these changes
Feb 10, 2020
iMacTia
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the Response Middleware enforces children classes to define public
parsemethod.This is due to the implicit arg
all_included=falsepassed to respond_to? methodNow I would like to allow also private and protected
parsemethod to allow more flexibility for the children classes.Todos
List any remaining work that needs to be done, i.e:
Additional Notes
When running
bundle exec rspecon master i noticed a bounce of failing specs which are not depending on this PR code changes.The error is:
and it refers to lib/faraday/adapter/rack.rb:62
Maybe an issue to fix that should be open.